'v-strings are deprecated at ./checksetup.pl line 316.' from checksetup.pl

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
--
trivial
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: bugzilla, Assigned: bugzilla)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

Assignee

Description

16 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-gb) AppleWebKit/124 (KHTML, like Gecko) Safari/125.1
Build Identifier: 

I get the above warning whenever I run checksetup.pl. Am I the only one?

The line in question is:

    if ($^V lt v5.8.0) {

I'm running cvs bugzilla, on OSX10.3, with perl, v5.8.1-RC3 built for darwin-thread-multi-2level

The man page for perlvar still uses this format as an example, so I'm not sure what (if anything) should 
replace this, but such a warning on installation should probably be avoided, somehow?


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

16 years ago
v-strings are now depreciated in perl 5.8.1.

Per http://www.mail-archive.com/perl5-porters@perl.org/msg66110.html we should 
do the following replacement:

v-strings NNNN.NNNN.NNNN

-->

pack('U*',NNNN,NNNN,NNNN).
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: MacOS X → All
Hardware: Macintosh → All

Updated

16 years ago
Severity: normal → trivial
Assignee

Comment 2

16 years ago
This patch replaces the v-string with a pack(). I've done a few tests comparing
$^V with pack('U*',5,8,1) and it seemed to work for me, but I don't have a
WIN32 install or earlier versions of Perl to test this on.
Assignee: zach → bugzilla
Status: NEW → ASSIGNED
Assignee

Updated

16 years ago
Attachment #144783 - Flags: review?

Comment 3

16 years ago
Comment on attachment 144783 [details] [diff] [review]
Patch to replace depreciated v-strings

This works for perl 5.6.1 and 5.6.0 and 5.8 (tested on landfill).
Attachment #144783 - Flags: review? → review+

Updated

16 years ago
Flags: approval?
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 2.18

Comment 4

16 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.270; previous revision: 1.269
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.