238711 - 500 error when trying to cancel a per-bug flag if a second flag of the same type exists

Status: RESOLVED DUPLICATE of bug 223878

(Bugzilla :: Attachments & Requests, defect)

Description

[Vlad Dascalu]

This is what the server log reports:

attachment.cgi: Use of uninitialized value in concatenation (.) or string at 
Bugzilla/FlagType.pm line 74.
[error] [client 217.73.164.14] malformed header from script. Bad 
header=</pre>: /opt/webtools/bugzilla/attachment.cgi
attachment.cgi: DBD::mysql::st execute failed: You have an error in your SQL 
syntax.  Check the manual that corresponds to your MySQL server version for 
the right syntax to use near '' at line 1 [for statement ``SELECT 1, 
flagtypes.id, flagtypes.name, flagtypes.description, flagtypes.cc_list, 
flagtypes.target_type, flagtypes.sortkey, flagtypes.is_active, 
flagtypes.is_requestable, flagtypes.is_requesteeble, 
flagtypes.is_multiplicable FROM flagtypes WHERE flagtypes.id = '']) at 
Bugzilla/DB.pm line 66
attachment.cgi:      Bugzilla::DB::SendSQL('SELECT 1, flagtypes.id, 
flagtypes.name, flagtypes.description, f...') called at Bugzilla/FlagType.pm 
line 74
attachment.cgi:      Bugzilla::FlagType::get(undef) called at Bugzilla/Flag.pm 
line 639
attachment.cgi:      Bugzilla::Flag::perlify_record() called at 
Bugzilla/Flag.pm line 82
attachment.cgi:      Bugzilla::Flag::get(59062) called at Bugzilla/Flag.pm 
line 155
attachment.cgi:      Bugzilla::Flag::validate('HASH(0x82038f8)', 238675) 
called at /opt/webtools/bugzilla/attachment.cgi line 151

Comment 1

[Vlad Dascalu]

Dave: you might want this for 2.18.

Comment 2

[Jouni Heikniemi]

Looking at the code and the stack trace, this happens when you have a flag with
a NULL type_id field in your flags table. I can't try reproducing this with
cvs-tip now, but if somebody can, feel free. On our production installation
(2.17.1) I've done this before times and never encountered it; "this" means
having two per-bug flags on a single bug and then canceling one of them.

Vladd, any chance this might be due to one of your bizarre experiments with your
Bugzilla DB?

Comment 3

[Jouni Heikniemi]

Crap; I just reproed this on bmo, so it's not Vladd's db. See bug 223878 comment
6 and bug 208847 comment 19. Duplicating with the nuclear bug, as this seems to
have the same sort of error dumps.

*** This bug has been marked as a duplicate of 223878 ***