238864 - remove %FORM and %COOKIE from move.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Dave Miller [:justdave]]

This should be another easy one

82:if ( !defined $::FORM{'buglist'} ) {
108:foreach my $id (split(/:/, $::FORM{'buglist'})) {
129:    if (defined $::FORM{'comment'} && $::FORM{'comment'} !~ /^\s*$/) {
130:        $comment .= $::FORM{'comment'} . "\n\n";
146:my $buglist = $::FORM{'buglist'};

31:use vars qw($template $userid %COOKIE);
93:my $exporter = $::COOKIE{"Bugzilla_login"};

Comment 1

[Christian Reis]

Attachment: kiko_v1: untested

Note that I'm unable to test bug moving.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 144995 [details] [diff] [review]
kiko_v1: untested

looks good.  Moving isn't well supported anyway, and is likely to get rewritten
soon anyway when I do the inter-bugzilla communication stuff :)

My only concern with this is:
+foreach my $id (split(/:/, $cgi->param('buglist'))) {

split() is a function, and as such, $cgi->param needs to be wrapped in scalar()
to prevent getting a return value in list context.  r+ with that fixed.

Comment 3

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.26; previous revision: 1.25

Thanks.