remove %FORM and %COOKIE from move.pl

RESOLVED FIXED in Bugzilla 2.18

Status

()

enhancement
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: justdave, Assigned: kiko)

Tracking

2.17.7
Bugzilla 2.18
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment)

This should be another easy one

82:if ( !defined $::FORM{'buglist'} ) {
108:foreach my $id (split(/:/, $::FORM{'buglist'})) {
129:    if (defined $::FORM{'comment'} && $::FORM{'comment'} !~ /^\s*$/) {
130:        $comment .= $::FORM{'comment'} . "\n\n";
146:my $buglist = $::FORM{'buglist'};

31:use vars qw($template $userid %COOKIE);
93:my $exporter = $::COOKIE{"Bugzilla_login"};
Blocks: 236678
No longer blocks: 225818
Note that I'm unable to test bug moving.
Assignee: nobody → kiko
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.18
Attachment #144995 - Flags: review?(justdave)
Comment on attachment 144995 [details] [diff] [review]
kiko_v1: untested

looks good.  Moving isn't well supported anyway, and is likely to get rewritten
soon anyway when I do the inter-bugzilla communication stuff :)

My only concern with this is:
+foreach my $id (split(/:/, $cgi->param('buglist'))) {

split() is a function, and as such, $cgi->param needs to be wrapped in scalar()
to prevent getting a return value in list context.  r+ with that fixed.
Attachment #144995 - Flags: review?(justdave) → review+
Flags: approval+
Severity: normal → enhancement
/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.26; previous revision: 1.25

Thanks.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.