239140 - Hard coded browser references in download.js

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Scott MacGregor]

The pref window chrome url is a hard coded browser urrl in the new download manager:

  var topWindow = windowManagerInterface.getMostRecentWindow("Browser:Options");
  if (topWindow) {
    topWindow.focus();
    topWindow.switchPage("catDownloadsButton");
  }
  else
    openDialog("chrome://browser/content/pref/pref.xul", "PrefWindow",
              "chrome,titlebar,resizable,modal", "catDownloadsButton");

I can make this more generic for thunderbird by making the prefwindow chrome URL
a preference which both apps can set. But that won't help with the search for
"Browser:Options" and "catDownloadsButton".

Ben do you think I should just ifdef this with the thunderbird specific stuff or
create 3 preference strings:

1) pref window chrome url
2) name of the options dialog (Browser:OPtions, Mail:Options)
3) catDownloadsButton id (I can probably just make sure I use the same id here)

Comment 1

[Scott MacGregor]

I think this bug is obsolete. The download manager no longer has UI hooks to the options dialog IIRC.

Comment 2

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change