239275 - select object's onchange event fires without change

Status: RESOLVED FIXED

(Camino Graveyard :: HTML Form Controls, defect)

Description

[Sebastian Winkler]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040317 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040317 Camino/0.7+

With a select object, when selecting the same option that already had been
selected, Camino wrongly fires the onchange event.
No other browaser does that.

Reproducible: Always
Steps to Reproduce:
1. Click on a select object, thus expanding it
2. Select the already active option


Actual Results:  
onchange is fired

Expected Results:  
it shouldn't

Comment 1

[Sebastian Winkler]

Attachment: test case

Comment 2

[Mike Pinkerton (not reading bugmail)]

shouldn't be too hard to fix in the native popup list form control code

Comment 3

[Scott MacVicar]

Attachment: patch to stop onchange event triggering for already selected element

first time i've sent in a patch but I think this is correct

Comment 4

[Mike Pinkerton (not reading bugmail)]

doesn't this stop it from firing any action if there is already a selection?

Comment 5

[Scott MacVicar]

selected is for that specific option not all options.

Found another bug, onclick doesn't appear to fire at all. Thats prior to this
patch, I'll see how complicated it is to fix and file another bug if appropriate.

Comment 6

[Josh Aas]

I looked at the patch, but I don't have time to get the background I'd need to
say whether or not this change is safe. Anybody know why this sort of code is in
Camino's embedding and not part of cocoa widgets (mozilla/widgets)?

Comment 7

[Josh Aas]

Comment on attachment 158141 [details] [diff] [review]
patch to stop onchange event triggering for already selected element

I'd rather the review came from someone else for this one...

Comment 8

[Josh Aas]

Comment on attachment 158141 [details] [diff] [review]
patch to stop onchange event triggering for already selected element

Time to get this one in - this needs careful reviewing and a good amount of
testing.

Comment 9

[Geoff "temporarily off bugmail" Beier]

Comment on attachment 158141 [details] [diff] [review]
patch to stop onchange event triggering for already selected element

This just gives me "malformed patch" when I attempt to apply. Am I doing
something wrong, or is this attachment only partially uploaded, or what?

Comment 10

[Josh Aas]

Attachment: patch that isn't malformed

I'm not saying I reviewed this patch for correctness, but the patch I am
attaching applies correctly.

Comment 11

[Josh Aas]

looks good to me r=josh

Comment 12

[Josh Aas]

landed

Comment 13

[Josh Aas]

landed on both trunk and 0.8.2 branch