239390 - clipboard should watch "xpcom-shutdown" instead of forcing nsAppRunner.cpp to call ForceDataToClipboard

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Benjamin Smedberg]

Currently, nsAppRunner.cpp has to call ForceDataToClipboard before xpcom
shutdown. This seems really silly to me, and can hurt embedders. The clipboard
implementations that needs this functionality should just implement nsIObserver
and watch the "xpcom-shutdown" topic.

Comment 1

[Mike Pinkerton (not reading bugmail)]

sounds fine by me. that ForceData code was needed because it was written LONG
before there was a shutdown notification mechanism.

Comment 2

[Brian Ryner (not reading)]

Attachment: patch

This is actually the reason that making -register use ScopedXPCOMStartup on the
aviary branch made gtk warnings happen (we ended up creating a clipboard
instance without initializing gtk).

This patch is against the aviary branch, and has actually been in the last few
Linux branch nightlies.

Comment 3

[Brian Ryner (not reading)]

A couple of minor corrections to this patch:

- nsBaseClipboard::ForceDataToClipboard should be removed
- os2/ and windows/ nsClipboard::Observe should have |const| on the aData parameter.

Comment 4

[Benjamin Smedberg]

This was fixed a while back:
nsAppRunner.cpp 1.32	bryner%brianryner.com	2004-06-10 13:39