239405 - strchr, strrchr, etc. implicit const_cast can cause problems for shared string buffers

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P1)

Description

[Darin Fisher]

strchr, strrchr, etc. implicit const_cast can cause problems for shared string
buffers.

see bug 239226.  we need to do some careful grepping of the tree to catch these
kinds of problems.

Comment 1

[Darin Fisher]

got about a dozen or so hits... attaching patch...

Comment 2

[Darin Fisher]

Attachment: v1 patch

Comment 3

[[e-mail]]

>     // move past "data:"
>-    const char *buffer = strstr(spec.get(), "data:");
>+    const char *buffer = strstr(spec.BeginWriting(), "data:");
>     if (!buffer) {
>         // malfored url
>         return NS_ERROR_MALFORMED_URI;
>     }
>     buffer += 5;
> 
>     // First, find the start of the data
>     char *comma = PL_strchr(buffer, ',');
Shouldn't buffer have its constness removed too, for consistency?

Comment 4

[Darin Fisher]

neil: yeah, good point.  i'll make that change.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 145317 [details] [diff] [review]
v1 patch

sr=dbaron given comment 3

Comment 6

[chris hofmann]

Comment on attachment 145317 [details] [diff] [review]
v1 patch

a=chofmann for 1.7

Comment 7

[Darin Fisher]

fixed-on-trunk for 1.7 final

Comment 8

[Darin Fisher]

.