239835 - Possible tray icon notification redirection

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

Before creating a system tray icon notification window nsMessengerWinIntegration
searches the whole window station for an existing window of the class
MailBiffNotificationMessageWindow. If such a window already exists, either from
running multiple debug builds, or from a malicious application, then any shell
icon notifications will be linked that instance rather than the instance trying
to show the icon.

Comment 1

[[e-mail]]

Attachment: First go at a patch

This makes the window handle a global so we never have to search for a previous
instance.

Comment 2

[Scott MacGregor]

Neil I forgot where we left of with this discussion yesterday. Are there
problems with this patch that need investigation or different approaches we were
talking about besides this one?

Comment 3

[[e-mail]]

I was wondering whether you were happy with these globals, perhaps these
variables and methods should be part of the nsMessengerWinIntegration.cpp object
- so for instance you could destroy the window when the object is destroyed.

Comment 4

[Scott MacGregor]

Comment on attachment 145566 [details] [diff] [review]
First go at a patch

I don't really have a preference one way or the other. Btw, I think you
accidentally removed a curly brace at the top of this patch.

sr=mscott if you want to go the global route.

Comment 5

[Walter K.]

> #define NOTIFICATIONCLASSNAME "MailBiffNotificationMessageWindow"

It used to be app name dependent, so different mail apps could run if one had
them. Now, all mail applications will be referencing the same biff window, i.e.
tb and sm cannot run together.

Or was it not working like that before?

Comment 6

[[e-mail]]

(In reply to comment #5)
>>#define NOTIFICATIONCLASSNAME "MailBiffNotificationMessageWindow"
>
>It used to be app name dependent, so different mail apps could run if one 
>had them. Now, all mail applications will be referencing the same biff window, 
>i.e. tb and sm cannot run together.
>
>Or was it not working like that before?
I don't think so... anyway, this way it's better, because it doesn't search for
previous instances so you can even run release & debug simultaneously :-)

Comment 7

[[e-mail]]

Attachment: Updated for bitrot

Comment 8

[[e-mail]]

Comment on attachment 150275 [details] [diff] [review]
Updated for bitrot

Transferring mscott's sr.

Comment 9

[[e-mail]]

Comment on attachment 150275 [details] [diff] [review]
Updated for bitrot

Switching reviewer.

Comment 10

[[e-mail]]

Fix checked in.