Note: There are a few cases of duplicates in user autocompletion which are being worked on.

remove [noscript] from nsICookieManager2::add

RESOLVED FIXED in mozilla1.8.1

Status

()

Core
Networking: Cookies
P1
trivial
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: Mathieu Fenniak, Assigned: Darin Fisher)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
mozilla1.8.1
fixed1.8.0.2, fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nvn-dl])

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/124 (KHTML, like Gecko) Safari/125.1
Build Identifier: 

I've built a Mozilla/Firefox extension that allows a web developer to edit cookies.  The only problem is 
that while nsICookieManager provides an interface to remove and read cookies, it does not provide a 
corresponding method to add a cookie.  nsICookieManager2 has a perfectly appropriate method, but it 
is marked [noscript].  If this were removed, my extension would work.  I cannot find any other way to 
do this - nsICookieService's API is not similar and doesn't allow the same direct access to the cookie 
database.

I don't know of any reason for this method to be [noscript].  Is there any?

Reproducible: Always
Steps to Reproduce:

Comment 1

14 years ago
> I don't know of any reason for this method to be [noscript].  Is there any?

I'm not sure that PRInt64 can be reflected into JS.  But more to the point, this
whole method is "not for public consumption", as the comments say.  Is there a
reason nsICookieService is not sufficient for your needs?

Comment 2

14 years ago
How does your extension allow editing of cookies? By removing and adding the cookie?
This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/
This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → EXPIRED
(Assignee)

Comment 5

12 years ago
I'm reopening this bug.  It should never have been closed.  Gerv! ;-)

(In reply to comment #1)
> > I don't know of any reason for this method to be [noscript].  Is there any?
> 
> I'm not sure that PRInt64 can be reflected into JS.  But more to the point, this
> whole method is "not for public consumption", as the comments say.  Is there a
> reason nsICookieService is not sufficient for your needs?

PRInt64 is completely scriptable.  nsICookieService is not sufficient because it may result in the user being prompted to accept new cookies.  That prevents extensions from doing clever and possibly useful things with the cookie database.
Status: RESOLVED → UNCONFIRMED
Resolution: EXPIRED → ---
(Assignee)

Updated

12 years ago
Severity: normal → trivial
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Target Milestone: --- → mozilla1.8.1
(Assignee)

Comment 6

12 years ago
Created attachment 212822 [details] [diff] [review]
v1 patch

trivial patch.
Attachment #212822 - Flags: superreview?(bzbarsky)
Attachment #212822 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

12 years ago
Comment on attachment 212822 [details] [diff] [review]
v1 patch

I'd really like this to be fixed for FF 1.5.0.2 if possible.  I have this JS-only extension that could really benefit from this.
Attachment #212822 - Flags: approval1.8.0.2?
Attachment #212822 - Flags: approval-branch-1.8.1?(dveditz)

Comment 8

12 years ago
Comment on attachment 212822 [details] [diff] [review]
v1 patch

r+sr=bzbarsky.  Should we work on freezing this?
Attachment #212822 - Flags: superreview?(bzbarsky)
Attachment #212822 - Flags: superreview+
Attachment #212822 - Flags: review?(bzbarsky)
Attachment #212822 - Flags: review+
(Assignee)

Comment 9

12 years ago
yes, perhaps we should.
(Assignee)

Comment 10

12 years ago
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
Comment on attachment 212822 [details] [diff] [review]
v1 patch

Sorry, doesn't fit in scope of security/stability release, and too late for a ride-along
Attachment #212822 - Flags: approval1.8.0.2?
Attachment #212822 - Flags: approval1.8.0.2-
Attachment #212822 - Flags: approval-branch-1.8.1?(dveditz)
Attachment #212822 - Flags: approval-branch-1.8.1+
Comment on attachment 212822 [details] [diff] [review]
v1 patch

Darin convinced us, approved for 1.8.0 branch, a=dveditz for drivers
Attachment #212822 - Flags: approval1.8.0.2- → approval1.8.0.2+
(Assignee)

Comment 13

12 years ago
fixed1.8.1, fixed1.8.0.2
Keywords: fixed1.8.0.2, fixed1.8.1

Updated

12 years ago
Whiteboard: [nvn-dl]
*** Bug 331254 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.