Closed Bug 240219 Opened 16 years ago Closed 16 years ago

checksetup.pl displays an invalid PPM command for Perl5.6

Categories

(Bugzilla :: Installation & Upgrading, defect, P1)

x86
Windows XP
defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: goobix, Assigned: goobix)

Details

Attachments

(1 file, 1 obsolete file)

Perl5.6 for Windows ships with version 2 of the PPM.
Perl5.8 for Windows ships with version 3 of the PPM.

While both of them have the same command for installing ppm modules, adding a 
new repository is done differently in version 2 and in version 3.

We already differenciate between Perl 5.6 and Perl 5.8 because we point the 
users to different repositories (a 5.6 ppm module is not generally compatible 
with a 5.8 one).

However, in both cases we use the same command to add the repository. Sadly, 
the command is valid only for PPM version 3 (Perl 5.8). If we are running under 
5.6, then PPM version 2 is installed and we must use another command.

The commands for version 2 and version 3 are explicited in the first paragraphs 
of http://www.bribes.org/perl/ppmdir.html .

I tested the new command on a Perl 5.6 system and it works. The old command 
failed unsuccesfully.
Status: NEW → ASSIGNED
Flags: blocking2.18?
Target Milestone: --- → Bugzilla 2.18
Priority: -- → P1
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #145859 - Flags: review?(kiko)
Flags: blocking2.18? → blocking2.18+
Attachment #145859 - Flags: review?(timeless)
Comment on attachment 145859 [details] [diff] [review]
Patch v1

>     if ($^V lt pack('U*',5,8,0)) {
>+        # Perl 5.6 has been detected. Point the user to a 5.6 repository,
please fix the comment to match the logic, thanks :)
Attachment #145859 - Flags: review?(timeless) → review+
Attachment #145859 - Flags: review?(kiko)
Attached patch V2Splinter Review
Attachment #145859 - Attachment is obsolete: true
Attachment #145893 - Flags: review?(timeless)
Attachment #145893 - Flags: review?(timeless) → review+
Flags: approval?
Flags: approval? → approval+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.275; previous revision: 1.274
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.