240300 - IDN: Domain in "Connection refused" dialog poorly encoded

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Crispin Flowerday (not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040329 Galeon/1.3.14
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040329 Galeon/1.3.14

Forwarded from http://bugzilla.gnome.org/show_bug.cgi?id=139341

If an IDN website isn't running, then the "Connection refused" dialog encodes
the   URL incorrectly, and instead of getting the correct UTF-8 chars, you get
garbage.

Reproducible: Always
Steps to Reproduce:
1. Go to an IDN site that is in DNS, but isn't running (the reporter of the
original galeon bug gave http://刘莉.dyndns.info/ as an example (but
it may be running sometimes))
2. wait for the "Connection refused" dialog


Actual Results:  
The dialog box has a very badly encoded dialog box.

Expected Results:  
The dialog box should have the correctly displayed URL

Comment 1

[Crispin Flowerday (not receiving bug mail)]

Attachment: Screenshot showing the poorly encoded URL in the alert

Comment 2

[Jungshik Shin]

Re comment #0:
Please, make sure to set View | Character Encoding to UTF-8 before typing
non-ASCII strings in bugzilla. 

Comment 3

[Daniel Kenzelmann]

http://刘莉.dyndns.info/
(With UTF-8 Encoding)

Comment 4

[Jungshik Shin]

Confirming and taking. 
UTF-8 strings are zero-padded when converting to UTF-16. 

Comment 5

[Jungshik Shin]

re comment #4: that is, 'string' is used where 'AUTF8String' should be used or
something like that. 

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

the symptom of comment 4 sounds more like AssignWithConversion is used where
CopyUTF8toUTF16 should be used. |string| instead of |AUTF8String| would cause
stripping of the high byte.

Comment 7

[Jungshik Shin]

You're absolutely right. The screenshot confirmed that.

Comment 8

[Jungshik Shin]

Attachment: patch

It seems like nhotta missed two places while making his patch for bug 122705.

Comment 9

[Jungshik Shin]

Comment on attachment 150439 [details] [diff] [review]
patch

asking for r/sr

Comment 10

[Jungshik Shin]

fixed on the trunk