240372 - Cannot Dnd from Mozilla Address book to other App

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Louie Zhao]

I am unable to Dnd addresses from Mozilla Address book to other applications.

Steps:
1)Open Mozilla Address book 
2)Create new address using New card window and save.
3)Drag this address from the list of addresses and try to drop on any
application (Ex:A new message in evolution or gedit).
4)Dnd does not happen.

However note that user can Dnd a contact on to a mozilla mail "TO or CC" fields.

Comment 1

[Louie Zhao]

Attachment: patch v1

add an additional flavor.

Comment 2

[Thomas Hedden]

I was about to file an "enhancement" bug for this myself,
but I found this bug, so I'll add my comments here.
IMHO, I don't agree with the reporter that it has to be
possible to drag-and-drop address book entries to ANY
application in ANY context (although it would certainly
be nice), but I think that it SHOULD be possible to add
them as ATTACHMENTS to e-mail messages produced in Mozilla
itself. This could be done to send an address book entry
to someone else. The recipient of the message should then
be able to drag and drop this attachment onto his/her own
address book, creating a new entry with the same information
as in the address book of the sender.
Some checking has to be done for duplicates, etc.
There HAS TO BE a simple way of transferring INDIVIDUAL
address book entries without opening each entry and
copying and pasting each individual field into a message
and then having the recipient perform the reverse steps,
or exporting the entire address book and having the
recipient import the entire address book.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 145989 [details] [diff] [review]
patch v1

I looked at this patch a couple of weeks ago. It seems to work well to other applications (though terminals on kde just the first letter is displayed for some strange reason).

However my main nit with this would be that the email addresses come out in the form:

myname1 <me1@me>

Is this really what we want if the user is dragging to other applications or do we want just the emails addresses themselves?

Hmmm, we also need to check what happens to mailing lists.

Comment 4

[[e-mail]]

Comment on attachment 145989 [details] [diff] [review]
patch v1

A list of names and addresses sounds good to me, but feel free to come up with an alternative ;-)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 145989 [details] [diff] [review]
patch v1

Seeing as this patch has been around a while, setting sr request for this patch early now that it has r+.

Comment 6

[Mark Banner (:standard8)]

Ok, I just checked the patch in:
/cvsroot/mozilla/mailnews/addrbook/resources/content/abDragDrop.js,v  <--  abDragDrop.js
new revision: 1.22; previous revision: 1.21

Reassign to Louie before resolving as fixed as he fixed the bug.

Comment 7

[OstGote!]

If this fix is not only for PC/Linux, then please change the fields accordingly.

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 145989 [details] [diff] [review]
patch v1

First a=me

Comment 9

[Ian Neal]

Comment on attachment 145989 [details] [diff] [review]
patch v1

a=me for SM1.0b on SM only part of code, 2nd needed one - What Ho!

Comment 10

[[e-mail]]

Whoops, this is a shared file. Sorry :-(

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #9)
> (From update of attachment 145989 [details] [diff] [review] [edit])
> a=me for SM1.0b on SM only part of code, 2nd needed one - What Ho!
> 
This won't go in as SM only as abDragDrop.js is shared between Thunderbird & SeaMonkey - it'll have to wait for 1.1 & co. 

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 145989 [details] [diff] [review]
patch v1

Requesting branch approval - this has been in trunk for quite a while already.

Comment 13

[Mark Banner (:standard8)]

Checked into branch