240420 - <style> elements flub line numbers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

When a <style> element's script (inline script) is parsed, the first line of the
script is treated as line 1 instead of being treated as whatever line it
actually is in the source file.  These elements should do what <script> elements
do, probably (and we'll need some changes to nsICSSLoader and nsICSSParser to
pass the numbers along, of course).  <svg:style> would need to be fixed too,
naturally.

This is something we need for CSS error reporting, basically.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase for CSS error reporting

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch for HTML style elements

This fixes HTML style elements.  I don't see content sink code for others, so
they're harder.

Comment 3

[Boris Zbarsky [:bzbarsky]]

There's code in the XML content sink, no?  Look in
nsXMLContentSink::CreateElement (and search for InitStyleLinkElement)?

The patch looks pretty good and changing the XML sink accordingly should be
simple.  Want to do that and I'll mark reviews?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase for CSS error reporting (XHTML)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 158287 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-09-09 10:32 -0700.