If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Tell config tools where .idl files are installed

RESOLVED FIXED

Status

SeaMonkey
Build Config
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: Braden, Assigned: Christian Persch (GNOME) (away; not receiving bug mail))

Tracking

({fixed-aviary1.0.8, fixed1.7.6})

Trunk
All
Linux
fixed-aviary1.0.8, fixed1.7.6

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

14 years ago
It would be nice if there were a means of determining where Mozilla's .idl files
are installed. I'm thinking simply an "idldir" variable in mozilla-xpcom.pc
should be sufficient.

Comment 1

14 years ago
mozilla-config has --idlflags although right now the proper value doesn't get
substituted into the file.

Comment 2

14 years ago
Created attachment 146470 [details] [diff] [review]
Fix mozilla-config (checked in)

Updated

14 years ago
Attachment #146470 - Flags: review?(bsmedberg)

Updated

14 years ago
Attachment #146470 - Flags: review?(bsmedberg) → review+

Updated

14 years ago
Attachment #146470 - Attachment description: Fix mozilla-config → Fix mozilla-config (checked in)
Product: Browser → Seamonkey
(Reporter)

Comment 3

13 years ago
Created attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata
(Reporter)

Updated

13 years ago
Attachment #172356 - Flags: review?(bsmedberg)
(Reporter)

Comment 4

13 years ago
seawood's patch does not appear to have been checked in on the 1.7 branch. I
think it really ought to be (along with mine).
Flags: blocking1.7.6?
(Reporter)

Updated

13 years ago
Attachment #146470 - Flags: approval1.7.6?
(Reporter)

Updated

13 years ago
Attachment #172356 - Flags: approval1.7.6?
(Reporter)

Updated

13 years ago
Flags: blocking1.7.6?
(Reporter)

Updated

13 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

13 years ago
Assignee: nobody → braden
Status: ASSIGNED → NEW

Comment 5

13 years ago
Comment on attachment 146470 [details] [diff] [review]
Fix mozilla-config (checked in)

a=mkaply for 1.7.6
Attachment #146470 - Flags: approval1.7.6? → approval1.7.6+
Attachment #172356 - Flags: approval1.7.6?
Keywords: fixed1.7.6
(Reporter)

Comment 6

13 years ago
Removed keyword fixed1.7.6. The remaining patch to fix (on 1.7.6 and otherwise)
this is still awaiting review.
Keywords: fixed1.7.6

Comment 7

13 years ago
Is "idldir" a standard of some sort?
(Reporter)

Comment 8

13 years ago
Of *some* sort? I suppose... it's the variable name for that directory used by
mozilla-config. So it's consistent with the existing convention.

Updated

13 years ago
Attachment #172356 - Flags: review?(benjamin) → review+
(Reporter)

Updated

13 years ago
Attachment #172356 - Flags: approval1.7.6?

Comment 9

13 years ago
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

a=mkaply
Attachment #172356 - Flags: approval1.7.6? → approval1.7.6+

Comment 10

13 years ago
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

mozilla/build/unix/Makefile.in	1.23
mozilla/build/unix/mozilla-xpcom.pc.in	1.3

mozilla/build/unix/Makefile.in	1.21.2.1
mozilla/build/unix/mozilla-xpcom.pc.in	1.1.102.2
Attachment #172356 - Attachment is obsolete: true
(Reporter)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.7.6
Resolution: --- → FIXED
Comment on attachment 146470 [details] [diff] [review]
Fix mozilla-config (checked in)

This was never checked in to aviary branch. It's an important fix, and has no
risk.
Attachment #146470 - Flags: approval-aviary1.0.4?
(Reporter)

Comment 12

13 years ago
Christian: Is there a reason you didn't flag the pkg-config metadata fix for 
Aviary approval as well?
(Reporter)

Comment 13

13 years ago
And what about bug 279427?
Drivers are looking at 1.0.5 approval requests and this one has a bunch of
unanswered questions:

Do both patches need approval?
what about bug 279427 mentioned by Braden?
Why did timeless mark the second attachment obsolete, was only the first checked in?
Sorry for not responding earlier; this bug had somehow fallen off of my radar.

(In reply to comment #12)
> Christian: Is there a reason you didn't flag the pkg-config metadata fix for 
> Aviary approval as well?

The mozilla-config.in patch is a bugfix, while the other patch is a featurelet;
so I only requested a? for the first patch. But since the other patch is on 1.7
branch too, I guess it makes sense to request a? for the pkg-config patch too.
I'll do that in a minute.

(In reply to comment #13)
> And what about bug 279427?

Yeah, that should go on aviary too, for parity with 1.7 branch. I'll request a?
there.

(In reply to comment #14)
> Do both patches need approval?
Yes.

> what about bug 279427 mentioned by Braden?
See above.

> Why did timeless mark the second attachment obsolete, was only the first
checked in?

Don't know why it was marked obsolete; both patches are present on trunk and 1.7
branch.
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

Requesting a1.0.5 for parity with 1.7 branch.
Attachment #172356 - Flags: approval-aviary1.0.5?
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

not obsolete -- good patch we'd want if we port to aviary or other branch
Attachment #172356 - Attachment is obsolete: false

Comment 18

13 years ago
> Why did timeless mark the second attachment obsolete, was only the first
checked in?

Timeless marks checked in patches as obsolete.  See bug 115514#c5 .

Comment 19

12 years ago
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

1.0.5 has already shipped; removing approval request.
Attachment #172356 - Flags: approval-aviary1.0.5?

Updated

12 years ago
Attachment #146470 - Flags: approval-aviary1.0.5?
Comment on attachment 146470 [details] [diff] [review]
Fix mozilla-config (checked in)

Renominating for next round of branch release
Attachment #146470 - Flags: approval-aviary1.0.7?
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

Renominating for next round of branch release.
Attachment #172356 - Flags: approval-aviary1.0.7?
Comment on attachment 146470 [details] [diff] [review]
Fix mozilla-config (checked in)

a=dveditz for drivers
Attachment #146470 - Flags: approval-aviary1.0.8? → approval-aviary1.0.8+
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

a=dveditz for drivers
Attachment #172356 - Flags: approval-aviary1.0.8? → approval-aviary1.0.8+
(Reporter)

Comment 24

12 years ago
If someone thought this bug needed to be fixed on another branch, why wasn't it reopened?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

12 years ago
Assignee: braden → nobody
Status: REOPENED → NEW
(Reporter)

Comment 25

12 years ago
chpe: is there a reason you didn't also renominate bug 279427, or was that just an oversight?

Comment 26

12 years ago
Braden, bugs are marked FIXED when they are fixed on trunk. Branch landings are managed with keywords.
Status: NEW → RESOLVED
Last Resolved: 13 years ago12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 27

12 years ago
I see. Someone who cares about said branch is welcome to pick this up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Needs to land ASAP if this is still needed in the aviary101 branch
Assignee: nobody → chpe
Status: REOPENED → NEW

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
(In reply to comment #25)
> chpe: is there a reason you didn't also renominate bug 279427, or was that just
> an oversight?

I forgot to do that, yes.

Comment 30

12 years ago
Comment on attachment 172356 [details] [diff] [review]
Patch for pkg-config metadata

mozilla/build/unix/mozilla-xpcom.pc.in 	1.1.106.1.2.1 	AVIARY_1_0_1_20050124_BRANCH
Keywords: fixed-aviary1.0.8
You need to log in before you can comment on or make changes to this bug.