240724 - Memory leak in nsAccessibleWrap.cpp

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Philip K. Warren]

I have found a small memory leak in nsAccessibleWrap.cpp. Patch upcoming.

Comment 1

[Philip K. Warren]

Attachment: Patch v1

mInterfaces is initialzed with the following:

  mInterfaces = new MaiInterfacePointer[MAI_INTERFACE_NUM];

But it is never deleted in the destructor.

Comment 2

[Kyle Yuan]

Comment on attachment 146287 [details] [diff] [review]
Patch v1

nice catch. r=kyle.

Comment 3

[Henry Jia]

Comment on attachment 146287 [details] [diff] [review]
Patch v1

sr=Henry

Comment 4

[Philip K. Warren]

Comment on attachment 146287 [details] [diff] [review]
Patch v1

Requesting approval for a simple memory leak fix in the accessibility code.

Comment 5

[Philip K. Warren]

Patch checked in to trunk. Still waiting on 1.7 approval before marking this fixed.

Checking in nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAccessibleWrap.cpp,v  <-- 
nsAccessibleWrap.cpp
new revision: 1.11; previous revision: 1.10
done

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 146287 [details] [diff] [review]
Patch v1

a=mkaply

Comment 7

[Philip K. Warren]

Checked in to 1.7 branch.

Checking in nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAccessibleWrap.cpp,v  <-- 
nsAccessibleWrap.cpp
new revision: 1.10.2.1; previous revision: 1.10
done