240792 - favicons retrieved from HTTPS sites lost on shutdown

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mike Connor [:mconnor]]

Favicons retrieved from SSL sites are only stored in the memory cache, therefore
once the session ends and the memory cache is dumped, any bookmarks to that site
lose their favicons.

HTTPS vs. HTTP is fairly transparent to the normal user, so the disappearance of
the icon doesn't have any logical basis.  Since favicons are an IE-originated
hack, and they cache these between sessions, I don't think we really need to
honour the "secure" attribute in this case.

I think Neil's idea for storing this in data: URLs has the most promise, we just
need to decide on an update method.

Comment 1

[Mike Connor [:mconnor]]

in some cases, we actually get asked for HTTP auth on startup, see bug 133755

Comment 2

[Oliver Saier]

I kind of concur with Darin Fisher on what he wrote in #173762...
Assuming that any file being served through SSL is considered to be sensitive
data by the content provider, would you then have to warn end users about it
stored on disc?

Comment 3

[Doug Wright]

Fixed by 174265? (see comment 74)

Comment 4

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change