241479 - SOCKS: support for "Replies"

Status: NEW

(Core :: Networking: Proxy, defect, P5)

Description

[John Villalovos]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421

Trying to use the SOCKS proxy support with Mozilla 1.7RC1.  It does not work.  I
have used the same SOCKS proxy with Filezilla and I was able to connect to a
SFTP site using it.

I setup the SOCKS proxy server settings in Mozilla.  Shutdown Mozilla and all
related apps.  Started Mozilla and then tried to connect to:
irc://irc.mozilla.org/chatzilla

I receive the following errors.

[INFO]	Network view for “irc.mozilla.org” opened.
	[INFO]	Connecting to irc.mozilla.org via irc.mozilla.org:6667, attempt 1 of 5...
	[ERROR]	Connection to irc://irc.mozilla.org/ (irc://irc.mozilla.org/) closed
with status 2147500037.
	[INFO]	Connecting to irc.mozilla.org via irc.mozilla.org:6667, attempt 2 of 5...
	[ERROR]	Connection to irc://irc.mozilla.org/ (irc://irc.mozilla.org/) closed
with status 2147500037.
	[INFO]	Connecting to irc.mozilla.org via irc.mozilla.org:6667, attempt 3 of 5...
	[ERROR]	Connection to irc://irc.mozilla.org/ (irc://irc.mozilla.org/) closed
with status 2147500037.
	[INFO]	Connecting to irc.mozilla.org via irc.mozilla.org:6667, attempt 4 of 5...
	[ERROR]	Connection to irc://irc.mozilla.org/ (irc://irc.mozilla.org/) closed
with status 2147500037.
	[INFO]	Connecting to irc.mozilla.org via irc.mozilla.org:6667, attempt 5 of 5...
	[ERROR]	Connection to irc://irc.mozilla.org/ (irc://irc.mozilla.org/) closed
with status 2147500037.
	[ERROR]	Connection attempts exhausted, giving up.

I checked with the folks on the Chatzilla mailing list and they think it has to
do with the proxy code.

Reproducible: Always
Steps to Reproduce:

Comment 1

[John Villalovos]

Discovered that our SOCKS proxy does NOT allow access to port 6667.  So the
fault is not entirely Mozilla's.  It still would be nice if Mozilla gave a
better error message then.

status 2147500037 which I have been told means: NS_ERROR_FAILURE

When doing a packet capture Ethereal said that it got back from the proxy
server.  Connection not allowed by ruleset (2).

Comment 2

[Frank Wein [:mcsmurf]]

Mozilla would need to parse the replies of it, see
http://www.faqs.org/rfcs/rfc1928.html 6. Replies

Comment 3

[benc]

-> NEW.
I don't think anyone ever asked for this.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

sigh, the SOCKS code knows very well that the server sent "connection nto
allowed by ruleset"... in fact it knows all the other error codes  as well. it
just maps everything to NS_ERROR_FAILURE...

http://lxr.mozilla.org/seamonkey/source/netwerk/socket/base/nsSOCKSIOLayer.cpp#310

Comment 5

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258