241516 - css classes for bug, component, and status on show_bug can easily have name conflicts

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Dave Miller [:justdave]]

in the show_bug.html.tmpl, we add css classes to the body to let sites use css
to customize by component, status, or bug number.  However, we didn't do
anything to prevent the name of a status or component from causing a name
conflict with something in the site's standard css.  For example, if you have a
component named "Part1" and your normal css for layout stuff happens to have a
"part1" class anyway, your body for the bugs in the "Part1" component wind up
being styled not quite how you intended...

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

prepend what it is we're identifying to the class name

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 146884 [details] [diff] [review]
Patch v1

>+[% bodyattrs = BLOCK %]class='bz_bug status_[% bug.bug_status 
>+  FILTER css_class_quote %] component_[%+ bug.component 
>+  FILTER css_class_quote %] bug_[%+ bug.bug_id 

You don't need the plus signs anymore.	Also, wouldn't it make sense to prefix
everything with "bz_" or remove "bz_" from "bz_bug"?

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch v2

> Also, wouldn't it make sense to prefix
> everything with "bz_" or remove "bz_" from "bz_bug"?

Hmm, good idea.  I like the bz_ prefix idea because that even further reduces
the likelihood of a namespace collision.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 147010 [details] [diff] [review]
Patch v2

r=myk

Comment 5

[Dave Miller [:justdave]]

Checking in template/en/default/bug/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v  <--
 show.html.tmpl
new revision: 1.6; previous revision: 1.5
done