Closed
Bug 241568
Opened 20 years ago
Closed 5 years ago
<nsFrame.cpp> cleanup
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file, 1 obsolete file)
20.13 KB,
patch
|
Details | Diff | Splinter Review |
Fix for {{ <http://tinderbox.mozilla.org/SeaMonkey/warn1082809200.7591.html> anthonyd (2 warnings) 1. layout/html/base/src/nsFrame.cpp:3879 (See build log excerpt) `nsIFrame*thisBlock' might be used uninitialized in this function 2. layout/html/base/src/nsFrame.cpp:3908 (See build log excerpt) `nsIFrame*thisBlock' might be used uninitialized in this function }} (NB: lines should be lines - 2, due to checkin "in progress") will be included.
Assignee | ||
Comment 1•20 years ago
|
||
Also removes: {{ <http://lxr.mozilla.org/mozilla/search?string=RefreshContentFrames> RefreshContentFrames /layout/html/base/src/nsFrame.cpp, line 121 -- static void RefreshContentFrames(nsIPresContext* aPresContext, nsIContent * aStartContent, nsIContent * aEndContent); }} (There could be more cleanup to do: but enough for now.)
Assignee | ||
Updated•20 years ago
|
Assignee: nobody → gautheri
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 146923 [details] [diff] [review] (Av1) <nsFrame.cpp> I have no compiler: Could you compile/test/review this patch ? Thanks.
Attachment #146923 -
Flags: review?(rbs)
Comment 3•20 years ago
|
||
Note that nsFrame.cpp has nothing to do with HTML Frames, and I'm a little wary of anyone who doesn't know that touching this file....
I already reviewed a patch (by the same author) for the warnings in comment 0 in another bug. Code cleanup and warning fixes are really only beneficial to the maintainers of the code in question. So is cvs blame. Things like this mess up cvs blame, and I'm not sure the benefits are worth it.
Component: Layout: HTML Frames → Layout: Misc Code
Assignee | ||
Comment 5•20 years ago
|
||
(In reply to comment #4) > I already reviewed a patch (by the same author) for the warnings in comment 0 in > another bug. Are you sure ? May be that was an other warning from bug 217089: <http://bugzilla.mozilla.org/attachment.cgi?id=146892&action=view> !? > Code cleanup and warning fixes are really only beneficial to the maintainers of > the code in question. So is cvs blame. Things like this mess up cvs blame, and > I'm not sure the benefits are worth it. Well, there are some improvements too: let's wait for rbs's review...
Assignee | ||
Updated•20 years ago
|
Attachment #146923 -
Attachment is obsolete: true
Attachment #146923 -
Flags: review?(rbs)
Assignee | ||
Comment 6•20 years ago
|
||
Av1, "improved".
Assignee | ||
Updated•20 years ago
|
Attachment #147072 -
Flags: review?(rbs)
Comment on attachment 147072 [details] [diff] [review] (Av1b) <nsFrame.cpp> I am not really keen on this one, as it came from the coding style of the initial coder. It is only worth the time/effort if you are taking ownership of the file and asserting you style. [Note that the compiler will optimize most away -- except, e.g., that |if view| with multiple calls -- which isn't significant here]).
Attachment #147072 -
Flags: review?(rbs)
Updated•15 years ago
|
QA Contact: layout.html-frames → layout.misc-code
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
Comment 8•5 years ago
|
||
The code probably changed a lot in 10 years, closing
Status: ASSIGNED → RESOLVED
Type: defect → task
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•