241625 - "Open in tabs" doesn't focus content area in first tab

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Middle-click on a bookmark folder on the bookmarks toolbar.
2. Wait for the first page (at least) to load.
3. Press Down.

Expected: scroll the first page down
Result: nothing happens.

If I press Tab after step 2, the content area gains focus, and pressing Down works.

Comment 1

[Jesse Ruderman]

Attachment: patch

This changes openGroupBookmark to use w._content.focus() instead of
browser.focus().  browser.focus() seems to work correctly in the second case in
openOneBookmark but not in the first case in openOneBookmark or in
openGroupBookmark.

Comment 2

[Jesse Ruderman]

Bryner says this should be debugged so we know why the old code didn't work.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

bryner, any ideas on what to do about this?  I'm inclined to take this patch
as-is for 1.0..

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 149954 [details] [diff] [review]
patch

bandaid, will do for now.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 149954 [details] [diff] [review]
patch

a=[e-mail]

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in on aviary.

Comment 7

[Peter van der Woude [:Peter6]]

may have caused regression bug Bug 263060

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #7)
> may have caused regression bug Bug 263060

nope, just tested both with and without this patch.

Comment 9

[Tracy Walker [:tracy]]

verified fixed as seen on Windows 2004-10-07-06-0.9,  Mac 2004-10-07-05-0.9 and
linux 2004-10-07-09-0.9

Comment 10

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change