241712 - Need an XP way to restart the app

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

My extension manager mismatch checking invokes a modal UI during startup if
there are extensions/themes/etc that are incompatible with the starting version
of Firefox. In this case all extensions are disabled and new versions are
installed. This operation requires the browser to restart. 

As a result I need the startup code to call into me, and depending on the
result, restart the app. 

I have exposed a method on nsIExtensionManager that should be called after
profile start: 

unsigned short checkForMismatches();

which returns either nsIExtensionManager::MISMATCH_RESULT_OK if no
incompatibilities were discovered and the app can continue starting, or
nsIExtensionManager::MISMATCH_RESULT_RESTART if the UI was presented and a
restart is required.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

It just occurred to me that I should just return true or false. false = no
mismatches, carry on starting. true = mismatches, restart. 

now my method looks like this:

boolean checkForMismatches();

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

This is in on branch, not on trunk. 

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

This is not quite done... we need a solution for OS X still. execv doesn't seem
to work inside bundles. 

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

I checked in a fix using NSTask for MacOS X. 

Comment 5

[Benjamin Smedberg]

OK, the Big Three all work now. Marking fixed.