241722 - secmod.db from 1.6: Mozilla 1.7 crashes on each form button click

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[Marcus von Cube]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040422
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040422

After upgrading from 1.6 to 1.7rc1 on OS/2 I was unable to click any form button
(e. g. in Google). Mozilla comes to an immediate stop in LIBC04.DLL (see
additional info)

Deleting secmod.db in my profile cured the problem.

Can anybody tell me what the file does? Did I loose any information by deleting it?

N.B.: The problem does not occur with 1.6. I can still start and use 1.6 with
the "broken" file in place!

Reproducible: Always
Steps to Reproduce:
1. Have a profile with my "broken" secmod.db
2. Go to google
3. Press a button

Actual Results:  
Crash

Expected Results:  
Submit the form

POPUPLOG.OS2

04-26-2004  09:37:30  SYS3175  PID 0353  TID 0001  Slot 00d1
G:\MOZILLA\OS2\1.7\MOZILLA.EXE
c0000005
12248420
P1=00000001  P2=00000000  P3=XXXXXXXX  P4=XXXXXXXX  
EAX=030f0000  EBX=12380710  ECX=00000000  EDX=00000001
ESI=00000000  EDI=00000000  
DS=0053  DSACC=f0f3  DSLIM=ffffffff  
ES=0053  ESACC=f0f3  ESLIM=ffffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:12248420  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:0012ea04  SSACC=f0f3  SSLIM=ffffffff
EBP=0012ea1c  FLG=00012212

LIBC04.DLL 0001:00018420

Comment 1

[Marcus von Cube]

Attachment: "broken (?) secmod.db from my 1.6 profile

This is the secmod.db file from my original profile. It works fine with Mozilla
1.6 but brakes 1.7rc1.

Comment 2

[Mike Kaply [:mkaply]]

The only thing I could imagine here is that somehow 1.7 is using the 1.6 version
of NSSCKBI.DLL and having problems, but that shouldn't be an issue.

Because the crash is in LIBC05, I can't get much info out of it.

I tried your exact scenario (using a 1.6 NSSCKBI with 1.7) and I did not crash,
So I am not sure where to go from here....

Comment 3

[Julien Pierre]

Marcus,

Do you have encryption enabled for your passwords / forms in Mozilla ? See Edit
/ Preferences/ Privacy & Security / Passwords / Use encryption when storing
sensitive data.

If so, Mozilla will need to initialize security whenever you load a form with
memorized userid/password information.

There are some known issues moving between VACPP and gcc builds, if secmod.db
points to an nssckbi.dll built with the other compiler. However, 1.6 and 1.7
were both built with gcc ...

To further diagnose the problem (the following info might be more useful for
Mike after the problem is reproduced) :

1) do you have two separate copies of Mozilla in different directories, ie. one
for 1.6 and another for 1.7 ? or did you overwrite the 1.6 binaries with 1.7 ?

2) use the "strings" tool to extract the strings from secmod.db and check where
nssckbi.dll is getting loaded frrom. You should see if it's getting loaded from
your 1.6 or 1.7 build

Comment 4

[Mike Kaply [:mkaply]]

The secmod.db that is posted in this bug definitely references 1.6.

Comment 5

[Marcus von Cube]

(In reply to comment #4)
> The secmod.db that is posted in this bug definitely references 1.6.

That's clear, because I simply reused my profile which was created by Mozilla
many versions before...

Comment 6

[Marcus von Cube]

(In reply to comment #3)

> Do you have encryption enabled for your passwords / forms in Mozilla ? See Edit
> / Preferences/ Privacy & Security / Passwords / Use encryption when storing
> sensitive data.

No.

> If so, Mozilla will need to initialize security whenever you load a form with
> memorized userid/password information.

The crash does occur on the submit, not on the load of the form. And on any
form, not only forms with passwords.

> To further diagnose the problem (the following info might be more useful for
> Mike after the problem is reproduced) :
> 
> 1) do you have two separate copies of Mozilla in different directories, ie. one
> for 1.6 and another for 1.7 ? or did you overwrite the 1.6 binaries with 1.7 ?

I have seperate directories for each version.

> 2) use the "strings" tool to extract the strings from secmod.db and check where
> nssckbi.dll is getting loaded frrom. You should see if it's getting loaded from
> your 1.6 or 1.7 build

[see Mike's comment an my reply]

Why is there version specific stuff in my profile directory? If that can't be
avoided, then Mozilla should either remove or upgrade the respective files or
keep them in seperate paths or under distinct names. 

Comment 7

[Julien Pierre]

Marcus, to answer your last 2 questions, see bug 240956 and bug 176501 .
To summarize :

1) mozilla is doing something wrong by trying to share secmod.db in the profile
between different versions of the code

2) in addition, on OS/2, there is a porting bug that caused the DLLs from one
compiler not to load under the other compiler. Until now that problem was only
observed between VACPP and gcc builds. However, 1.6 and 1.7 were both built with
gcc, so that's something new.

I don't have time to try to reproduce your crash this week. I suggest you work
with Mike. I would like to see a full stack of the problem if it gets reproduced.

Comment 8

[knut st. osmundsen]

The crash is in _ucalloc(Heap_t h, size_t count, size_t size), h is NULL (edi)
and the first attempt to access it (the assertion) crashes.

The user is not using the fixed LIBC04.DLL. This problem might have been fixed
in fix1 (I'm saying might because I don't know who is calling _ucalloc() in this
case). Please download and install the fix1 for LIBC04 before proceeding. 

Comment 9

[Marcus von Cube]

(In reply to comment #8)
> The user is not using the fixed LIBC04.DLL. This problem might have been fixed
> in fix1 (I'm saying might because I don't know who is calling _ucalloc() in this
> case). Please download and install the fix1 for LIBC04 before proceeding. 

With my latest installed build 
>>Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7) Gecko/20040426<<
and libc04fix1 the problem went away.

Are there any issues in removing my older Mozilla-Versions? Since secmod.db
references a dll of a different version, will Mozilla fail if I remove the old
version?

Comment 10

[Mike Kaply [:mkaply]]

> Are there any issues in removing my older Mozilla-Versions? Since secmod.db
> references a dll of a different version, will Mozilla fail if I remove the old
> version?

Nope. If we don't find the version referenced in secmod.db, we look for it in
the current Mozilla install.

Glad to see the new libc04 fixed this.

Marking WORKSFORME.