241731 - bookmarks sidebar creates empty contextmenu when no items are selected

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P5)

Description

[Sekundes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040422 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040422 Firefox/0.8.0+

     

Reproducible: Always
Steps to Reproduce:
1.Ctrl + B.
2.the caret should be focus on the search textbox rather than the items of
bookmarks.
3.right click on the empty area of the bookmarks tree view.
Actual Results:  
empty contextmenu is created.

Comment 1

[Ali Ebrahim]

I'm pretty sure that at some point I've seen something like this been reported
before, but I can't find anything to dupe it against! Maybe I'm wrong and I'm
thinking of something else. mconnor will probably know.

But this bug is certainly real.

Comment 2

[Mike Connor [:mconnor]]

not where I can test this, this is more like a bookmarks bug though.

empty as in blank?  what does Bookmarks Manager do with nothing selected?  
maybe we need that behaviour implemented?

Comment 3

[Ali Ebrahim]

Yeah, empty as in it creates a tiny contextmenu with nothing inside it. Note
that to reproduce this you need to open the bookmarks sidebar and focus on the
search caret and make sure that nothing else is selected in the sidebar.

Then right click on some empty whitespace below the bookmarks, and you'll see
this. Your bookmarks list has to be sufficiently short that it doesn't take up
the entire screen so you get some whitespace.

--> minor
--> Bookmarks

Comment 4

[Anders Pedersen]

Confirmed.

The focus is on the search textbox when I open the bookmarks sidebar CTRL+B, but
I get that empty context menu when clicking on the whitespace below the bookmarks.

- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040522
Firefox/0.8.0+
- Microsoft Windows 2000 Pro 5.00.2195 SP4

Comment 5

[Blake Ross]

Should be simple to fix, and it's a little bit sloppy in a finished product. If
we can get to it, great, otherwise it's the first thing cut ;)

Comment 6

[Kyle Yuan]

Attachment: do not popup context menu when selection is undefined

Comment 7

[Asa Dotzler [:asa]]

blake, ben, can one of you review this short patch? 

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 153389 [details] [diff] [review]
do not popup context menu when selection is undefined

>   createContextMenu: function (aEvent, aSelection)
>   {
>+    if (aSelection == undefined) {
>+      aEvent.preventDefault();
>+      return;
>+	}
>+

fix the tab here, and the spacing for the closing bracket, and r=me.

Comment 9

[Kyle Yuan]

Comment on attachment 153389 [details] [diff] [review]
do not popup context menu when selection is undefined

fixed in trunk. waiting approval for aviary branch.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 153389 [details] [diff] [review]
do not popup context menu when selection is undefined

a=asa for branch checkin.

Comment 11

[Kyle Yuan]

fixed in aviary branch.

Comment 12

[Mike Connor [:mconnor]]

*** Bug 259148 has been marked as a duplicate of this bug. ***

Comment 13

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change