Closed Bug 242121 Opened 20 years ago Closed 19 years ago

port patches in bug 181973 to support reversed="true" in listitems

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bzbarsky, Assigned: mconnor)

References

Details

(Whiteboard: already works for checkboxes) 

I don't know when exactly prefs got forked, so I'm not sure which of those
patches, if any apply.  The nsWidgetStateManager and nsPrefWindow code hasn't
changed much in toolkit, though....
Summary: Probably need porting of patches in bug 181973 → Probably need porting of patches in bug 181973
anciently forked, Feb 1st 2003 IIRC

I'll take a look at this, probably this weekend.
Assignee: firefox → mconnor
You're not the first one with this idea, see bug 225476. But this bug seems to
be far more active, so I'll dupe that bug to this one.

There's also bug 191410, which already has a patch (with previnverse though).
Maybe you can fix that as well while you're at it.
OS: Linux → All
Hardware: PC → All
*** Bug 225476 has been marked as a duplicate of this bug. ***
Blocks: 191410
Sorry, I meant bug 236666, not bug 191410. Bug 236666 now has a patch with the
"reversed" attribute, see bug 236666 comment 13. So I guess the work is already
done.

*** This bug has been marked as a duplicate of 236666 ***
No longer blocks: 191410
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Steffen, one thing that the patch in bug 181973 did that we don't have (nor does
the patch in Bug 236666 add) is support for the reversed attribute in listitems
(we do support it in checkboxes though). I don't know if it's worth porting that
in case it's needed in the future?
Right: pref-advancedscripts.xul has listitems which values are copied from
hidden checkboxes in pref-features.xul with reversed="true", and where that works.
A comment would've been nice there...

Reopening and adjusting summary. If it works for checkboxes, it should work for
listitems type="checkbox" as well. Mike, do you still want to do that? Hand it
over to Pike or me if you don't.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Summary: Probably need porting of patches in bug 181973 → port patches in bug 181973 to support reversed="true" in listitems
Whiteboard: already works for checkboxes
The new prefwindow has fixed this, as far as I can see. See for example
attachment 175687 [details] [diff] [review]. Note that the attribute is placed on <preference> element, so
there's no need to do it for every widget.
WFM, based on gavin's comments
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → WORKSFORME
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.