Closed Bug 242161 Opened 16 years ago Closed 16 years ago

process_bug.cgi doesn't contain patchviewer ("diff") like show_bug.cgi

Categories

(Bugzilla :: Attachments & Requests, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: steffen.wilberg, Assigned: bugzilla)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Steps to reproduce:
1. Have a buglist.
2. Modify one bug, so that process_bug.cgi is displayed with the next bug in
your list.
Notice that patches have an "edit" button, but no "diff" button.

3. Click on the bug number, so that show_bug.cgi displays the same bug.
Notice that the patch now has the "diff" button.

This is a bit confusing. I first thought something's wrong with the patch.
Probably has something to do with a template parameter not getting passed
through.  I think we currently have a similar problem with the CSS file.
Target Milestone: --- → Bugzilla 2.20
Attached file Add PatchViewer check into process_bug (obsolete) —
Assignee: myk → bugzilla
Status: NEW → ASSIGNED
Comment on attachment 149649 [details]
Add PatchViewer check into process_bug

wrong file - ignore!
Attachment #149649 - Attachment is obsolete: true
Attachment #149649 - Attachment is patch: false
Attachment #149650 - Flags: review?
Attachment #149650 - Flags: review? → review+
Flags: approval?
Flags: approval? → approval+
Target Milestone: Bugzilla 2.20 → Bugzilla 2.18
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.205; previous revision: 1.204
done

Changing resolution to FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> Probably has something to do with a template parameter not getting passed
> through.  I think we currently have a similar problem with the CSS file.

Dave: Do you have more info on the similar problem with css?

no, but that's worthy of another bug, which might actually already be filed. 
Something to do with obsolete attachments and resolved dependencies not showing
with strike-through.
(In reply to comment #7)
> no, but that's worthy of another bug, which might actually already be filed. 

I couldn't find any existing bugs related to what you mention here...

> Something to do with obsolete attachments and resolved dependencies not showing
> with strike-through.

Obsolete attachments and resolved dependencies seemed to be stroked-through(!) for me, on 
show_bug and process_bug, so unless anyone can point me at a bug, I'm going to let this one go..
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.