242416 - Classic theme: text in highlighted Aqua button turns white while active

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Brion Vibber]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040502
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040502

When clicking an Aqua-styled button in a dialog, the button's label text turns
white while it's active. Real Aqua buttons don't do this; the text should remain
black the whole time.

Reproducible: Always
Steps to Reproduce:
1. Load up Mozilla in the default Classic theme.
2. Open some dialog (say, Preferences or Find)
3. Click a button.

Actual Results:  
While clicked, the button's text changes from black to white.

Expected Results:  
The button's text should not change color.

The problem is with the Classic theme that comes with Seamonkey; the Pinstripe
theme in Firefox 0.8 gets this right.

Comment 1

[Brion Vibber]

Attachment: Screenshot showing incorrect text color on the depressed Cancel button (should be black text)

Comment 2

[Greg K.]

Confirmed using Mac/1.7b (2004042110). WFM using Firefox/20040416, though, so
maybe Gerich’s eventual Pinstripe for Mozilla will fix this and all the other
old Mac Classic theme bugs.

Comment 3

[Brion Vibber]

Attachment: One-line fix to remove the hardcoded white text

I'm guessing the hardcoded white text was originally put in for the old Mac OS
-- where depressed buttons _do_ have white text -- and just never got updated
for OS X. Since Mozilla no longer supports CFM builds that run on the old Mac
OS, there's no need to try to determine which system is being run on; it can
just be taken out as in this patch.

Comment 4

[Greg K.]

Brion, don’t forget to request review for your patch. Setting blocking1.7?.

Comment 5

[Brion Vibber]

Attachment: One-line fix for white text button problem (fixed)

Removes, rather than comments out, the offending line.

Comment 6

[[e-mail]]

I don't know why I got CC'd on this because I don't have a Mac, but I was
wondering why the colour was hardcoded in in the first place because in the
Windows classic theme there are virtually no literal colours, system colour
identifiers are used almost throughout.

Comment 7

[[e-mail]]

Comment on attachment 147796 [details] [diff] [review]
One-line fix for white text button problem (fixed)

I suggest someone with access to a mac reviews this...

Comment 8

[Stefan [:stefanh]]

Comment on attachment 147796 [details] [diff] [review]
One-line fix for white text button problem (fixed)

Peter, can you take a look at this? glazou told me on irc that you're a mac
person :)

Comment 9

[Stefan [:stefanh]]

Comment on attachment 147796 [details] [diff] [review]
One-line fix for white text button problem (fixed)

Neil, can you sr this one-liner?

Comment 10

[[e-mail]]

Comment on attachment 147796 [details] [diff] [review]
One-line fix for white text button problem (fixed)

rs=me (platform-specific code)

Comment 11

[[e-mail]]

Fix checked in.