Closed
Bug 242446
Opened 21 years ago
Closed 21 years ago
nsHttpNegotiateAuth::MatchesBaseURI fixes
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: cneberg, Assigned: darin.moz)
Details
(Keywords: fixed1.7, Whiteboard: fixed-aviary1.0)
Attachments
(1 file)
|
1.85 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
asa
:
approval1.7+
|
Details | Diff | Splinter Review |
1st fix. hostStart contains all of the remaining matches from the pref, so it
will match against the colon in the next entry if the port is not there.
const char *hostEnd = strchr(hostStart, ':');
- if (hostEnd) {
+ if (hostEnd && hostEnd <= baseEnd) {
2nd fix, subdomain matching
- // now, allow host to be a subdomain of matchHost
+ // now, allow matchhost to be a subdomain of host
- if (matchHost.Length() > hostLen)
+ if (matchHost.Length() < hostLen)
{
debugmsg("subdomain Failed!", "");
return PR_FALSE;
|
Reporter | |
Updated•21 years ago
|
Flags: blocking1.7+
|
Assignee | |
Comment 1•21 years ago
|
||
as a patch
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 147557 [details] [diff] [review] v1 patch r+sr=darin
Attachment #147557 -
Flags: superreview+
Attachment #147557 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
fixed-on-trunk cneberg: thanks for the patch! also, only drivers@mozilla.org can set the blockingX.Y+ flags. normal folks have to set the '?' variant, and wait for drivers to approve or disapprove.
Status: NEW → RESOLVED
Closed: 21 years ago
Flags: blocking1.7+ → blocking1.7?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha
|
|
Assignee | |
Updated•21 years ago
|
Attachment #147557 -
Flags: approval1.7?
|
|
Assignee | |
Comment 4•21 years ago
|
||
drivers: this bug prevents the negotiate auth preferences from working correctly. without this patch, the negotiate auth feature is pretty much useless.
|
||
Comment 5•21 years ago
|
||
Comment on attachment 147557 [details] [diff] [review] v1 patch a=asa (on behalf of drivers) for checkin to 1.7
Attachment #147557 -
Flags: approval1.7? → approval1.7+
|
|
Assignee | |
Comment 8•21 years ago
|
||
(In reply to comment #7) > AVIARY_1_0_20040515_BRANCH does not checkin yet. actually, the patch was checked in on the aviary1.0 branch. i guess i just didn't mention that.
Whiteboard: fixed-aviary1.0
You need to log in
before you can comment on or make changes to this bug.
Description
•