242489 - routeEvent should warn to JS console that it's not implemented

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See discussion in bug 242429

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is implemented by nsHTMLDocument and nsGlobalWindow.  The basic idea is to
get the console service and log some (localized) warning message to it. 
Something similar to what the code at RectArea::ParseCoords does (with a
"warning" flag).

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Wouldn't the patch in bug 82878 along with a queryable keyword be a better
solution to this problem?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Myk, wrong bug?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Indeed.  Sorry about that.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Note that at this point it would be better to use
nsContentUtils::ReportToConsole instead of copying the RectArea code.

Comment 6

[Vidar Haarr (not reading bugmail)]

I see that both
<http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsGlobalWindow.cpp#2970>
and
<http://lxr.mozilla.org/seamonkey/source/content/html/document/src/nsHTMLDocument.cpp#2828>
have "implemented" routeEvent; must the nsContentUtils::ReportToConsole be
implemented both places, or can I for example get a reference to nsGlobalWindow
from nsHTMLDocument ?

Comment 7

[Vidar Haarr (not reading bugmail)]

I noticed that mScriptGlobalObject in nsHTMLDocument is a reference to the
nsGlobalWindow (nsGlobalWindow.h implements nsIScriptGlobalObject) - thanks to
Neil for confirming that.

So I guess that means we can do (in nsHTMLDocument):
  nsCOMPtr<nsGlobalWindow> gW = do_QueryInterface(mScriptGlobalObject);
  gW->routeEvent(aEvt);

Or ? But the QI above doesn't work.. Any pointers ?

Comment 8

[Boris Zbarsky [:bzbarsky]]

You can't QI to a concrete class.  You could QI to nsIDOMJSWindow, though, since
that's where routeEvent is defined.

Note that it's possible for a document to have no script global object, though.
 So it would make more sense for both method to call a static nsContentUtils
method or something.  Though using ReportToConsole() shouldn't take more than a
line or two of code, so it may be OK to just put it in both places.

Comment 9

[Vidar Haarr (not reading bugmail)]

Attachment: work in progress

Work in progress

Do I need to check for sourceURI or doc ? If they are null, I guess we should
just report it with no source file ?

Can I get the source location anywhere - I saw nsJSUtils::GetCallingLocation,
for example, can I use that?

Am I using the right report category ("content javascript") ?

I believe the actual warning message needs some work as well :)

Comment 10

[Vidar Haarr (not reading bugmail)]

bz: Any hints on how to get the linenumber, etc here ?
I noticed also that the last patch has an unused nsresult.

Comment 11

[Boris Zbarsky [:bzbarsky]]

You may try to get the current stack frame off nsIXPConnect and getting the line
number from that... I'm not sure whether that will give you the start of the
function, though.

Chances are, there is no good way to get a line number here.

I'm not sure what else you're having trouble getting; could you elaborate?

Comment 12

[timeless]

have you looked at DumpJSStack() (fanout is painful), i can't remember if it does what you want or not.

Comment 13

[Anant Narayanan [:anant]]

This bug seems to have been solved already. Please close.