r:/mozilla\xpcom\io\nsStringStream.cpp(270) : warning C4244: 'initializing' : conversion from 'PRInt64' to 'PRInt32', possible loss of data This is because attachment 144227 [details] [diff] [review] (sr=mscott, no r=) changed the code to be broken. attachment 144054 [details] [diff] [review] (r=darin) would have been fine.
no, attachment 144054 [details] [diff] [review] would not have been fine: NS_ASSERTION(offset < 0xFFFFFFFF, "string streams only support 32 bit offsets"); would have generated a warning...
timeless: can you please explain what conditions lead to this warning? are you trying to use a string stream with more than 4GB of data or seek to a really distant position in the stream? how serious is this bug? is anything important affected?
Comment on attachment 147645 [details] [diff] [review] proposed fix r=darin
Attachment #147645 - Flags: review?(darin) → review+
Attachment #147645 - Flags: superreview?(mscott) → superreview+
i'm just trying to build.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.