nsStringStream.cpp(270) : warning C4244: 'initializing' : conversion from 'PRInt64' to 'PRInt32', possible loss of data

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: timeless, Assigned: Bienvenu)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

738 bytes, patch
Darin Fisher
: review+
Scott MacGregor
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
r:/mozilla\xpcom\io\nsStringStream.cpp(270) : warning C4244: 'initializing' :
conversion from 'PRInt64' to 'PRInt32', possible loss of data

This is because attachment 144227 [details] [diff] [review] (sr=mscott, no r=) changed the code to be broken.

attachment 144054 [details] [diff] [review] (r=darin) would have been fine.
(Assignee)

Comment 1

14 years ago
no, attachment 144054 [details] [diff] [review] would not have been fine:

 NS_ASSERTION(offset < 0xFFFFFFFF, "string streams only support 32 bit offsets");

would have generated a warning...

Comment 2

14 years ago
timeless: can you please explain what conditions lead to this warning?  are you
trying to use a string stream with more than 4GB of data or seek to a really
distant position in the stream?  how serious is this bug?  is anything important
affected?
(Assignee)

Comment 3

14 years ago
Created attachment 147645 [details] [diff] [review]
proposed fix
(Assignee)

Updated

14 years ago
Attachment #147645 - Flags: review?(darin)

Comment 4

14 years ago
Comment on attachment 147645 [details] [diff] [review]
proposed fix

r=darin
Attachment #147645 - Flags: review?(darin) → review+
(Assignee)

Updated

14 years ago
Attachment #147645 - Flags: superreview?(mscott)

Updated

14 years ago
Attachment #147645 - Flags: superreview?(mscott) → superreview+
(Reporter)

Comment 5

14 years ago
i'm just trying to build.
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.