242599 - Use default.ico for default top-level window icon on Windows

Status: RESOLVED INVALID

(Core :: XUL, defect)

Description

[Robert Parenton]

On GTK2, the icon for toplevel windows is initially set to default.xpm, and if
an icon with the window ID as the filename (e.g. main-window.xpm) exists in
chrome/icons/default/ then the default icon is overridden with that.

To properly fix Bug 171349 on Windows builds, we should "port" that behavior
from GTK2.

The relevant checkins to add this functionality to GTK2 were:

This is the CVS checkin that accomplished the original default.xpm stuff on GTK2:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2002-08-10+11%3A06&maxdate=2002-08-10+11%3A08&cvsroot=%2Fcvsroot


This is where the default.xpm fallback was added to GTK2:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsWindow.cpp&branch=&root=/cvsroot&subdir=mozilla/widget/src/gtk2&command=DIFF_FRAMESET&rev1=1.36&rev2=1.37
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsWindow.cpp&branch=&root=/cvsroot&subdir=mozilla/widget/src/gtk2&command=DIFF_FRAMESET&rev1=1.54&rev2=1.55

Comment 1

[Robert Parenton]

This has been obsoleted by the fix in Bug 171349