242650 - [10.1] "Get Info" on bookmark folders shows black window

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Mireille]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040503 Camino/0.8b
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040503 Camino/0.8b

When I choose "Get Info" for a bookmark folder in the bookmark manager, the
window showed has a black background. "Get Info" for individual bookmarks work fine.

Reproducible: Always
Steps to Reproduce:
1. select bookmark folder
2. choose "Get Info"


Expected Results:  
A get info window like for the individual bookmarks, or none at all (if not
applicable to folders)

OS 10.1.5

Comment 1

[Mireille]

Attachment: Screenshot showing the bug.

The screenshot explains what is so hard to put into words.

Comment 2

[Stuart Morgan]

Wow, it sure does (2004050408 0.8b).  WFM in the same build on 10.3.3.  I'm
guessing this is another 10.1 bug for me, since we've never head of it before,
but can someone with 10.2 confirm for me?

Putting on the 0.8 list and taking, since it's probably 10.1 (and needs to be
fixed by 0.8 either way).

Mireille, is this a recent regression? Could you possibly check some older
builds to see if/when it used to work?

Comment 3

[Mireille]

I've used a nightly from early April before and it was there, too.

Comment 4

[Greg K.]

WFM using Camino/2004050308 (v0.8b) on OS X 10.2.8.

Comment 5

[Mike Pinkerton (not reading bugmail)]

stuart, can you play with the nib at all to see if we can correct this?

Comment 6

[Stuart Morgan]

Attachment: fix + general cleanup

This may be overkill, but the code for the info panel was such an ugly hack
that I couldn't help it. Instead of using the add-and-subtract-tabs-on-the-fly
method, this uses two views, one for bookmarks and one for folders, and swaps
them out as a whole.

In addition to fixing the 10.1 black background bug, it also:
-Fixes bug 243246 (as a side-effect)
-Removes code to disable keywords for non-group folders, since there's no
reason not to allow keywords on normal folders (it works just fine) and it was
handled in really inconsistent ways
-Makes the folder info pane look better since it's designed to fit the full
height
-Makes the code cleaner and shorter.

Comment 7

[Stuart Morgan]

Attachment: new nib

The corresponding new nib. My apologies to the l10n team.

Comment 8

[Stuart Morgan]

Comment on attachment 150776 [details] [diff] [review]
fix + general cleanup

Josh: the changes are restricted to BookmarkInfoController and the nib, so
hopefully the impact to your upcoming BM patch will be minimal.

Comment 9

[Stuart Morgan]

Mireille, thanks for catching this for us!

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed on trunk & branch