Closed Bug 242973 Opened 20 years ago Closed 20 years ago

when MAPISend is called with a plain text note (lpszNoteText) with newlines, we lose formatting

Categories

(MailNews Core :: Simple MAPI, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mscott, Assigned: Bienvenu)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(2 files, 2 obsolete files)

when MAPISend is called with a plain text note (lpszNoteText) with newlines, we
lose the formatting.

it is because we insert that text as html.

see
http://lxr.mozilla.org/mozilla/source/mailnews/mapi/mapihook/src/msgMapiHook.cpp#502
Is a duplicate of bug 196881
Attached patch proposed fixSplinter Review
send message as plain text
Comment on attachment 152631 [details] [diff] [review]
proposed fix

send mapi messages as plain text
Attachment #152631 - Flags: superreview?(mscott)
Attachment #152631 - Flags: superreview?(mscott) → superreview+
Attached patch fix non-blind send case (obsolete) — Splinter Review
if we're bringing up the compose ui, we can't just use plain text, so this fix
converts '\n' to <br> so that lines are retained.
Attachment #156455 - Flags: superreview?(mscott)
Attachment #156455 - Flags: superreview?(mscott) → superreview+
fixed on trunk, 1.0 branch, and m4 branch
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
previous fix causes problems with edit | draft/template with html
messages...reopening. new fix upcoming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch proposed fix (obsolete) — Splinter Review
check the compose type before converting crlfs (the mailto url doesn't work
because the caller code seems to strip out the crlfs, but if it didn't, this
would work )
Attachment #156455 - Attachment is obsolete: true
Attachment #156616 - Attachment is obsolete: true
Comment on attachment 156618 [details] [diff] [review]
proposed fix (prev attachment was from wrong dir)

check the compose type before converting crlfs (the mailto url doesn't work
because the caller code seems to strip out the crlfs, but if it didn't, this
would work )
Attachment #156618 - Flags: superreview?(mscott)
Attachment #156618 - Flags: superreview?(mscott) → superreview+
fixed on trunk and branch.
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
Product: MailNews → Core
*** Bug 196881 has been marked as a duplicate of this bug. ***
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: