All users were logged out of Bugzilla on October 13th, 2018

Making a change to gfx/src/shared does not cause a relink

RESOLVED FIXED in mozilla1.9alpha1

Status

RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: caillon, Assigned: cls)

Tracking

Trunk
mozilla1.9alpha1
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

2.42 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
This is quite annoying when editing .cpp files :(
(Assignee)

Comment 1

13 years ago
Created attachment 202058 [details] [diff] [review]
v1.0

This bug is due to a general dependency problem with our internal libraries.  If the library shows up on the link line as -lgfxshared_s, then the dependency rules at http://lxr.mozilla.org/seamonkey/source/config/rules.mk#635 won't work.  

Rather than trying to check for both static & shared internal library dependencies explicitly, we can add $(DIST)/lib to VPATH and use the GNU make .LIBPATTERNS feature to handle -lfoo dependencies listed in EXTRA_DSO_LIBS.
Attachment #202058 - Flags: review?(benjamin)

Comment 2

13 years ago
Comment on attachment 202058 [details] [diff] [review]
v1.0

I think we need to explicitly set .LIBPATTERNS to %.lib on Windows/MSVC and perhaps to lib%.dylib on mac.
Attachment #202058 - Flags: review?(benjamin) → review-
(Assignee)

Comment 3

13 years ago
Created attachment 202172 [details] [diff] [review]
v1.1

Good catch.  We can use the {DLL,LIB}_{PREFIX,SUFFIX} variables to properly set LIBPATTERNS.
Attachment #202058 - Attachment is obsolete: true
Attachment #202172 - Flags: review?(benjamin)
(Assignee)

Updated

13 years ago
Attachment #202172 - Flags: review?(benjamin)
(Assignee)

Comment 4

13 years ago
Created attachment 202200 [details] [diff] [review]
v1.2

Add import libraries to the list.  Fixes mingw bustage.
Assignee: general → cls
Attachment #202172 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #202200 - Flags: review?(benjamin)

Comment 5

13 years ago
Comment on attachment 202200 [details] [diff] [review]
v1.2

Great.
Attachment #202200 - Flags: review?(benjamin) → review+
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha

Updated

13 years ago
Depends on: 315718
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.