Change nsIOnReadystatechangeHandler to nsIOnReadyStateChangeHandler

RESOLVED FIXED

Status

()

Core
XML
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.86 KB, patch
jst
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
The mscom method is just an idispatch method

dispinterface XMLDOMDocumentEvents 
{
    properties:
    methods:
    [id (DISPID_XMLDOMEVENT_ONDATAAVAILABLE)]  
    HRESULT ondataavailable(void);
 
    [id (DISPID_XMLDOMEVENT_ONREADYSTATECHANGE)] 
    HRESULT onreadystatechange(void);
};

it has no case, so i'd like to change the mozilla interface to use a more
typical interCaps format.
I'll be happy to r+sr such a change if one is provided...
(Assignee)

Comment 2

14 years ago
Created attachment 148790 [details]
too many changes
(Assignee)

Updated

14 years ago
Attachment #148790 - Flags: superreview?(jst)
Attachment #148790 - Flags: review?(jst)
(Assignee)

Updated

13 years ago
Attachment #148790 - Attachment description: changes → too many changes
Attachment #148790 - Attachment is obsolete: true
Attachment #148790 - Attachment is patch: false
Attachment #148790 - Flags: superreview?(jst)
Attachment #148790 - Flags: review?(jst)
(Assignee)

Comment 3

13 years ago
Created attachment 148902 [details] [diff] [review]
per bug summary
(Assignee)

Updated

13 years ago
Attachment #148902 - Flags: superreview?(jst)
Attachment #148902 - Flags: review?(jst)
Comment on attachment 148902 [details] [diff] [review]
per bug summary

r+sr=jst. Thanks timeless!
Attachment #148902 - Flags: superreview?(jst)
Attachment #148902 - Flags: superreview+
Attachment #148902 - Flags: review?(jst)
Attachment #148902 - Flags: review+
(Assignee)

Updated

13 years ago
Attachment #148902 - Flags: approval1.8a1?
Comment on attachment 148902 [details] [diff] [review]
per bug summary

1.8a1 shipped, wanna land this on the trunk?
Attachment #148902 - Flags: approval1.8a1?
(Assignee)

Comment 6

13 years ago
mozilla/extensions/xmlextras/base/public/nsIXMLHttpRequest.idl 	1.25
mozilla/extensions/xmlextras/base/src/nsXMLHttpRequest.cpp 	1.109
mozilla/extensions/xmlextras/base/src/nsXMLHttpRequest.h 	1.42
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.