243692 - Bookmarks overflow menu should collapse when item is dragged out

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040501
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040501

Bug 201854 enabled drab and drop for the bookmarks overflow menu. However,
unlike other bookmarks folders this overflow menu does not collapse when an item
is dragged out of it. For consistency it should collapse (and of course reopen
if the item is dragged in again).

Reproducible: Always
Steps to Reproduce:
1. Drag an item... ah, forget it, it's all described already.




Patch is coming...

Comment 1

[Andreas Kunz]

Attachment: patch

Observe!

Comment 2

[Andreas Kunz]

Comment on attachment 148573 [details] [diff] [review]
patch

Requesting r= from Neil and sr= from alecf.

Comment 3

[[e-mail]]

Comment on attachment 148573 [details] [diff] [review]
patch

>         document.getElementById("BookmarksMenu").parentNode,
>-        document.getElementById("PersonalToolbar")
>+        document.getElementById("PersonalToolbar"),
>+        document.getElementById("bookmarks-chevron-container")
Can't you do the parentNode trick on the chevron? Also, if you insert the new
element into the middle of the array it avoids changing the last line ;-)

Comment 4

[Andreas Kunz]

Attachment: simpler patch

Comment 5

[Andreas Kunz]

Comment on attachment 148615 [details] [diff] [review]
simpler patch

Requesting r= from Neil and sr= from alecf.

Comment 6

[Andreas Kunz]

Comment on attachment 148615 [details] [diff] [review]
simpler patch

Changing sr= request to jag.

alecf: of course you may still give me sr=...

jag: if you happen to be faster, could you please also take a look at bug
243961?

These two bugs are really nice-to-have for 1.7. Especially the other one really
should go in.

Comment 7

[jag (Peter Annema)]

Comment on attachment 148615 [details] [diff] [review]
simpler patch

sr=jag

Comment 8

[Andreas Kunz]

Comment on attachment 148615 [details] [diff] [review]
simpler patch

Requesting approval for 1.7.

This is very low risk, and admittedly only somewhat visible.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 148615 [details] [diff] [review]
simpler patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 10

[[e-mail]]

Fix checked in to branch and trunk.

Comment 11

[baffclan]

I cannot reproduce 2004052208-trunk/WinXP-JA 
thanks for fixing this.

Comment 12

[Andreas Kunz]

Verified per last comment and own testing with current trunk nightly.
Thanky for spotting the inconsistency!