No keyboard shortcut for closing "in the sidebar" bookmarks sidebars

RESOLVED FIXED in Firefox 2 beta2

Status

()

defect
P5
minor
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: mano, Assigned: pilgrim)

Tracking

(Blocks 1 bug, {access})

2.0 Branch
Firefox 2 beta2
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040416 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040416 Firefox/0.8

Currently, the only way to close a non-bundled sidebar (e.g.
bugzilla/Blogupdates) is via the sidebar close button. We need to implement a
keyboard shortcut for it.


Reproducible: Always
Steps to Reproduce:

Comment 1

15 years ago
It would also help if the installed sidebars showed up in View-> Sidebar-> 
Keywords: access

Comment 2

15 years ago
This doesn't seem to be a dupe, so confirming.

If we want Firefox to be accessible to those who can't use the mouse, this is
definitely needed. I'm nominating F9 as a Close Siderbar button (don't confuse
this with Bug 184565 which suggested F9 as both Close *and Open* Sidebar button).

Prog.
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: bugzilla
Assignee: firefox → aaronleventhal
Component: General → Keyboard Navigation
QA Contact: bugzilla → jruderman

Updated

15 years ago
Blocks: firekey
Keywords: sec508
Priority: -- → P3

Updated

15 years ago
Priority: P3 → P5

Comment 3

14 years ago
Work around og to view menu
Severity: normal → minor
Keywords: sec508
Assignee: aaronleventhal → nobody
Component: Keyboard Navigation → Places
QA Contact: jruderman → places
Assignee

Comment 4

14 years ago
Rather than futzing with global keyboard shortcuts, I recommend we simply add the sidebar close button to the tab order, so the user can tab to it and press ENTER to close the sidebar.  Patch tested with Inspect32 and WindowEyes 5.5 on Windows; close button is exposed as role=pushbutton, name="Close sidebar" (localized) and read correctly by WindowEyes.
Attachment #211146 - Flags: review?(mconnor)

Comment 5

14 years ago
Changing to keyboard navigation component. Places doesn't even have a sidebar.
Component: Places → Keyboard Navigation
Assignee

Updated

13 years ago
Assignee: nobody → pilgrim
Assignee

Updated

13 years ago
Attachment #211146 - Flags: ui-review?(beltzner)
Attachment #211146 - Flags: review?(mconnor)
Attachment #211146 - Flags: review?(bugs.mano)
Comment on attachment 211146 [details] [diff] [review]
Patch to add sidebar close button to tab order

Is there any focus feedback (i.e. outline) when the button is focused?
Assignee

Comment 7

13 years ago
Yes, the entire close button icon is enclosed in the usual focus rectangle.
Assignee

Comment 8

13 years ago
I'm updating the status whiteboard field so I can run an intenral report.  Don't interpret this as impatience; I know things are crazy right now.
Whiteboard: [review needed]
The patch seems to have rotted (on branch, at least) a little bit. I hacked the CSS manually, though, and didn't see the effect (on Mac). But maybe we should be supporting the close tab (Accel-W) shortcut in the sidebar instead of tabbing over to the closebutton? Otherwise you get this weird effect where you've got the sidebar in focus (with a focus rect!) and Accel-W closes the tab that's *not* currently given focus.
Assignee

Comment 10

13 years ago
Re-diffed against latest trunk.

I disagree with Beltzner that changing the behavior of Accel-W is the appropriate solution for this bug.  The behavior you describe already exists (lots of sidebars can have focused elements, but Accel-W still closes the unfocused browser tab), but this patch doesn't make that inconsistent behavior any worse.

And yeah, you won't see the focus rectangle on Mac OS X.  Test on Windows or Linux or some other platform that shows focus rectangles on random things.
Attachment #211146 - Attachment is obsolete: true
Attachment #222904 - Flags: superreview?(beltzner)
Attachment #222904 - Flags: review?(bugs.mano)
Attachment #211146 - Flags: ui-review?(beltzner)
Attachment #211146 - Flags: review?(bugs.mano)
Assignee

Updated

13 years ago
Target Milestone: --- → Firefox 2 beta1
QA Contact: places → keyboard.navigation
Comment on attachment 222904 [details] [diff] [review]
Focusable close box

Setting the right flag
Attachment #222904 - Flags: superreview?(beltzner) → ui-review?(beltzner)
Comment on attachment 222904 [details] [diff] [review]
Focusable close box

I still think it's strange that the non-focused tab gets closed on accel-w, but that's a separate bug, I guess.
Attachment #222904 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 222904 [details] [diff] [review]
Focusable close box

This will do for now, r=mano.
Attachment #222904 - Flags: review?(bugs.mano) → review+

Updated

13 years ago
Whiteboard: [review needed] → [checkin needed]
trunk: mozilla/browser/base/content/browser.css 1.20
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Version: unspecified → 2.0 Branch
You need to log in before you can comment on or make changes to this bug.