243752 - No keyboard shortcut for closing "in the sidebar" bookmarks sidebars

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P5)

Description

[Asaf Romano (gone)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040416 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040416 Firefox/0.8

Currently, the only way to close a non-bundled sidebar (e.g.
bugzilla/Blogupdates) is via the sidebar close button. We need to implement a
keyboard shortcut for it.


Reproducible: Always
Steps to Reproduce:

Comment 1

[Aaron Leventhal]

It would also help if the installed sidebars showed up in View-> Sidebar-> 

Comment 2

[Prognathous]

This doesn't seem to be a dupe, so confirming.

If we want Firefox to be accessible to those who can't use the mouse, this is
definitely needed. I'm nominating F9 as a Close Siderbar button (don't confuse
this with Bug 184565 which suggested F9 as both Close *and Open* Sidebar button).

Prog.

Comment 3

[Dan Kinnunen]

Work around og to view menu

Comment 4

[Mark Pilgrim (inactive)]

Attachment: Patch to add sidebar close button to tab order

Rather than futzing with global keyboard shortcuts, I recommend we simply add the sidebar close button to the tab order, so the user can tab to it and press ENTER to close the sidebar.  Patch tested with Inspect32 and WindowEyes 5.5 on Windows; close button is exposed as role=pushbutton, name="Close sidebar" (localized) and read correctly by WindowEyes.

Comment 5

[Brett Wilson]

Changing to keyboard navigation component. Places doesn't even have a sidebar.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 211146 [details] [diff] [review]
Patch to add sidebar close button to tab order

Is there any focus feedback (i.e. outline) when the button is focused?

Comment 7

[Mark Pilgrim (inactive)]

Yes, the entire close button icon is enclosed in the usual focus rectangle.

Comment 8

[Mark Pilgrim (inactive)]

I'm updating the status whiteboard field so I can run an intenral report.  Don't interpret this as impatience; I know things are crazy right now.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

The patch seems to have rotted (on branch, at least) a little bit. I hacked the CSS manually, though, and didn't see the effect (on Mac). But maybe we should be supporting the close tab (Accel-W) shortcut in the sidebar instead of tabbing over to the closebutton? Otherwise you get this weird effect where you've got the sidebar in focus (with a focus rect!) and Accel-W closes the tab that's *not* currently given focus.

Comment 10

[Mark Pilgrim (inactive)]

Attachment: Focusable close box

Re-diffed against latest trunk.

I disagree with Beltzner that changing the behavior of Accel-W is the appropriate solution for this bug.  The behavior you describe already exists (lots of sidebars can have focused elements, but Accel-W still closes the unfocused browser tab), but this patch doesn't make that inconsistent behavior any worse.

And yeah, you won't see the focus rectangle on Mac OS X.  Test on Windows or Linux or some other platform that shows focus rectangles on random things.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 222904 [details] [diff] [review]
Focusable close box

Setting the right flag

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 222904 [details] [diff] [review]
Focusable close box

I still think it's strange that the non-focused tab gets closed on accel-w, but that's a separate bug, I guess.

Comment 13

[Asaf Romano (gone)]

Comment on attachment 222904 [details] [diff] [review]
Focusable close box

This will do for now, r=mano.

Comment 14

[Asaf Romano (gone)]

trunk: mozilla/browser/base/content/browser.css 1.20