243882 - Switch hints for left/right/top/bottom to ReflowFrame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We shouldn't really need to force a repaint when these change, I would think. 
Reflow should be invalidating as needed.

This might expose invalidation bugs in reflow, so would be a good alpha
candidate, I think....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: If we want to live dangerously..

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fwiw, I just tried the second patch on the testcases at
http://www.24fun.com/downloadcenter/benchjs/benchjs.html (which isn't saying
much, since it probably doesn't change most of those properties) and I didn't
see any obvious rendering issues.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 148708 [details] [diff] [review]
If we want to live dangerously..

I say let's try this, since it's early alpha, and see what breaks.  ;)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 148708 [details] [diff] [review]
If we want to live dangerously..

Okay.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

ah, oh well. alea jacta est and all that

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yeah.   If shit comes down, it's a simple backout.  ;)