Closed Bug 243882 Opened 16 years ago Closed 16 years ago

Switch hints for left/right/top/bottom to ReflowFrame

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: perf)

Attachments

(2 files)

We shouldn't really need to force a repaint when these change, I would think. 
Reflow should be invalidating as needed.

This might expose invalidation bugs in reflow, so would be a good alpha
candidate, I think....
Attached patch Like soSplinter Review
Fwiw, I just tried the second patch on the testcases at
http://www.24fun.com/downloadcenter/benchjs/benchjs.html (which isn't saying
much, since it probably doesn't change most of those properties) and I didn't
see any obvious rendering issues.
Comment on attachment 148708 [details] [diff] [review]
If we want to live dangerously..

I say let's try this, since it's early alpha, and see what breaks.  ;)
Attachment #148708 - Flags: superreview?(roc)
Attachment #148708 - Flags: review?(roc)
Comment on attachment 148708 [details] [diff] [review]
If we want to live dangerously..

Okay.
Attachment #148708 - Flags: superreview?(roc)
Attachment #148708 - Flags: superreview+
Attachment #148708 - Flags: review?(roc)
Attachment #148708 - Flags: review+
Assignee: nobody → bzbarsky
Checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
ah, oh well. alea jacta est and all that
Yeah.   If shit comes down, it's a simple backout.  ;)
Depends on: 284166
Depends on: 323291
Depends on: 331880
Depends on: 349946
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.