244026 - Use 7-Zip for SEI

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Using 7-Zip will dramatically reduce our download size.

Comment 1

[Ali Ebrahim]

Ben, we should use it for packaging the zipfiles too. It has a much better zip
compression algorithm too.

Comment 2

[Jesse Ruderman]

Comment 1 is bug 154965.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

use 7-zip if MOZ_INSTALLER_USE_7ZIP is set in the environment.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

This patch is not quite correct... in ParseInstallerCfg the removal of the \r
should look like this:

      if (substr($line, -2, 2) eq "\r\n") {
        $line = substr($line, 0, length($line) - 2) . "\n";
      }
      ($prop, $value) = ($line =~ m/(\w*)\s+=\s+(.*)\n/);

Comment 5

[Scott MacVicar]

I was working on this didn't realise a bug existed for it.

Isn't there an issue with the LGPL?

Comment 6

[Scott MacVicar]

Just checked the patch.

I was working on a patch for the wizard installer so that it uses 7-zip instead
of zip.

I'll check if a bug exists for this already.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

I cleared this with legal yesterday. There is no LGPL issue as a) it is used as
a tool and b) the 7zSD.sfx SEI stub is an example of "aggregation" (the file is
aggregated with the .7z file using copy /b a+b+c). Per the LGPL:

"mere aggregation of another work not based on the Library with the Library...on
a volume of a storage or distribution medium does not bring the other work under
the scope of this License."

... so our binary is untainted. 

Checked in on the trunk too, so marking this FIXED. 

This has been integrated with bryner's new cross-platform installer scripts, not
the old ActiveState ones. 

Comment 8

[Brant Gurganus]

To let it be known, the 7-zip stub does not have a good error message for
corrupt self-extracting archives.  It says "7-zip: unspecified error" or
something similar instead of saying the problem (corrupt) or suggesting a
solution (download again).  I filed a bug with 7-zip requesting a better error
message for this situation.