Closed Bug 244124 Opened 19 years ago Closed 19 years ago

Shift + scroll wheel moves back and forth through history

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: mikepinkerton)

Details

Attachments

(1 file, 1 obsolete file)

Using a scroll wheel with the shift key held down moves back and forth through
history. AFAIK, we should only be doing this on option scrolling, as
shift-scrolling should be for horizontal scrolling (which doesn't work).  There
are lots of reports of this in forums an comments, and I'm seeing it as well in
recent 0.8 branch nightlies.

I don't think this was always the behavior. Could someone check old nightlies
and see if this is a regression, and if so when it regressed?
depend or duplicate bug171680 ?
> depend or duplicate bug171680 ?

I believe that we have our own code that's independent of the prefs discussed in
that bug. If that's the case, it's neither.
Two questions:
-I checked an old 4/26 trunk build, and it was fine there. What regressed us?
-Shouldn't we be getting those values already from all.js?
Nevermind, the answers are
-Bug 241646
-I was looking at the wrong lines of code.

It seems like scrolling up and down with the shift key should be
normalscroll+shift not horizscroll+shift, but whatever.
Comment on attachment 148948 [details] [diff] [review]
enable horizontal scroll by shift+wheel again.

This makes it work, but it works *backwards*. Option+scroll for history is also
backwards.

The real problem is that we are using horizscroll prefs for both option and
shift. We can either override them with the normal ones or figure out why and
fix *that*, which seems like the better option.
Attachment #148948 - Flags: review-
Attached patch complete fixSplinter Review
Nevermind the last comment; I misunderstood horizscroll.

This makes shift-scroll and option-scroll work as they did before being "fixed"
for windows in all.js
Attachment #148948 - Attachment is obsolete: true
Comment on attachment 148960 [details] [diff] [review]
complete fix

We need this for trunk and branch
Attachment #148960 - Flags: superreview?(pinkerton)
Comment on attachment 148960 [details] [diff] [review]
complete fix

sr=pink
Attachment #148960 - Flags: superreview?(pinkerton) → superreview+
landed trunk and branch
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.