244124 - Shift + scroll wheel moves back and forth through history

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Using a scroll wheel with the shift key held down moves back and forth through
history. AFAIK, we should only be doing this on option scrolling, as
shift-scrolling should be for horizontal scrolling (which doesn't work).  There
are lots of reports of this in forums an comments, and I'm seeing it as well in
recent 0.8 branch nightlies.

I don't think this was always the behavior. Could someone check old nightlies
and see if this is a regression, and if so when it regressed?

Comment 1

[Hiro]

depend or duplicate bug171680 ?

Comment 2

[Stuart Morgan]

> depend or duplicate bug171680 ?

I believe that we have our own code that's independent of the prefs discussed in
that bug. If that's the case, it's neither.

Comment 3

[waverider]

Attachment: enable horizontal scroll by shift+wheel again.

Comment 4

[Stuart Morgan]

Two questions:
-I checked an old 4/26 trunk build, and it was fine there. What regressed us?
-Shouldn't we be getting those values already from all.js?

Comment 5

[Stuart Morgan]

Nevermind, the answers are
-Bug 241646
-I was looking at the wrong lines of code.

It seems like scrolling up and down with the shift key should be
normalscroll+shift not horizscroll+shift, but whatever.

Comment 6

[Stuart Morgan]

Comment on attachment 148948 [details] [diff] [review]
enable horizontal scroll by shift+wheel again.

This makes it work, but it works *backwards*. Option+scroll for history is also
backwards.

The real problem is that we are using horizscroll prefs for both option and
shift. We can either override them with the normal ones or figure out why and
fix *that*, which seems like the better option.

Comment 7

[Stuart Morgan]

Attachment: complete fix

Nevermind the last comment; I misunderstood horizscroll.

This makes shift-scroll and option-scroll work as they did before being "fixed"
for windows in all.js

Comment 8

[Stuart Morgan]

Comment on attachment 148960 [details] [diff] [review]
complete fix

We need this for trunk and branch

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 148960 [details] [diff] [review]
complete fix

sr=pink

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed trunk and branch