Closed
Bug 244178
Opened 20 years ago
Closed 20 years ago
Crash reloading gmail mailbox page
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
References
Details
(Keywords: crash, regression)
Attachments
(1 file)
1.77 KB,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
When logged into gmail, mozilla (trunk only) will crash if you reload the page. This is a regression from the recent nsWyciwygChannel changes I made where the wyciwyg channel now stores the data in the cache as UTF-16, and the channel actually advertices its charset. This caused child-frames of pages that are loaded from a wyciwyg channel to assume that their charset is UTF-16 (unless otherwise specified in the http channel etc), and this exposed a bug in nsScanner::Append() where it in this case didn't malloc a big enough buffer for the data it was given (see bug 244177). We should do two things here, we should make the scanner code not crash (by fixing bug 244177), and we should also make a document not take the charset from its parent if its parent is loaded from a wyciwyg channel since there's no relation between their charsets any more, at all).
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #148950 -
Attachment description: Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI ( → Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI (diff -w)
Attachment #148950 -
Flags: superreview?(darin)
Attachment #148950 -
Flags: review?(bzbarsky)
Updated•20 years ago
|
Comment 2•20 years ago
|
||
Comment on attachment 148950 [details] [diff] [review] Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI (diff -w) s/advertice/advertise/ in the comment, and r=bzbarsky.
Attachment #148950 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•20 years ago
|
||
*** Bug 243639 has been marked as a duplicate of this bug. ***
Comment 4•20 years ago
|
||
Comment on attachment 148950 [details] [diff] [review] Don't advertise the charset of a docshell that's loaded from a wyciwyg: URI (diff -w) sr=darin
Attachment #148950 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Comment 5•20 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 6•20 years ago
|
||
*** Bug 243269 has been marked as a duplicate of this bug. ***
Comment 7•20 years ago
|
||
*** Bug 245368 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•