244291 - Add/correct kbd shortcuts and text in help

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Stefan [:stefanh]]

This is basically taken from bug 232066, the shortcuts tracker.

From bug 224196 comment 6:
Add "Select All" (Ctrl+A/Cmd+A/Alt+A)
Add "Delete Previous Word" (Ctrl+Bksp/Alt+Bksp/Ctrl+Bksp)
Move "Open search" to Browser keys
Mac's Help Back/Forward might be Cmd+Arrow, rather than Alt+Arrow
Remove duplicate "Exit Mozilla" from Browser keys
Add "Edit Page" (Accel+E)
Add "New Blank Page" (Accel+Shift+N)
"Page Down/Space" should have a space after / to allow it to wrap
Add "Close Window" (Accel+Shift+W) when more than one tab
Remove Shift+Insert from Mac because it doesn't work
Lose the ) after Select Radio Button
Select All Messages might be Alt+A on Linux
Add "Get New Messages" (Accel+T)
Add "Get All New Messages" (Accel+Shift+T)
Send Message Now only applies when online (will send later when offline)
where Accel=Ctrl/Cmd/Ctrl

Also: Add Mark As Junk/Not Junk (J/Shift+J)

Finally, Mark Thread As Read and Move To Next Unread Message (T) needs to be
added - somehow it got lost by one of my patches in bug 236942...

Comment 1

[Stefan [:stefanh]]

Attachment: Patch

This patch fixes the following stuff (I did found some more things that could
be added/corrected):

Adds:
"Select All" to General Mozilla Shortcuts

"Edit Page" and "Close Window (when more than one tab)" to Page Navigation
Shortcuts

"Get New Messages" and "Get All New Messages" to General Mail & Newsgroups
Shortcuts

"Mark Thread as Read and Move to Next Unread Message", "Mark As Junk", "Mark As
Not Junk" and "Mark Message As Read by Date" to Message List Shortcuts

"(message will be sent later if offline)" to "Send Message Now" in Message
Compose Shortcuts

"New Composer Page" to Composer Shortcuts (Accel+Shift+N)

Removes:
The duplicate "Exit Mozilla" from Page Navigation Shortcuts

Shift+Insert from mac, The ) after "Select Radio Button"

The   in the empty table cells in all the shortcuts files - since the
column widths are set by css I didn't see any point of having them there

The references to the windows "File" menu in "Open Main Menu" and makes it
invisible for mac users. The main menu on Mac OS X is the Apple menu (not in
the Mozilla window).

Fixes: the space after / in Page Down/Space

Moves: "Open search engine page" to Page Navigation Shortcuts


The patch also fixes the reported shortcut errors in bug 244348

The wrong Help/Forward key for mac is already fixed in bug 241806

I Checked the Linux Shortcut for "Select All Messages" on Mozillazine - it
appears to be correct (Ctrl+A)

Oh, I haven't added "Delete Previous Word" - it looks like that will be taken
care of in bug 232063.

Comment 2

[Stefan [:stefanh]]

Comment on attachment 149112 [details] [diff] [review]
Patch

Can you please take a look at this, Neil?

Comment 3

[Stefan [:stefanh]]

Attachment: New version of Patch

Just saw that the keys for "Open Help and Support Center" in Help Window
Shortcuts hasn't been working for ages. So, this new version of the Patch
removes them.

Comment 4

[Stefan [:stefanh]]

Comment on attachment 149113 [details] [diff] [review]
New version of Patch

Another patch will come, will add some more shortcuts and changing Select All
Messages for Linux back to Alt+A...

Comment 5

[Stefan [:stefanh]]

Changing the summary to be more in line with what I'm doing...

Comment 6

[Stefan [:stefanh]]

Attachment: New patch with some more shortcuts and other corrections

This patch also adds some Composer shortcuts and changes "Find in Page" to
"Find and Replace". It also changes the Linux shortcut for "Select All
Messages" back to the original (Alt+A).
  
Some other corrections:
Changed "Edit as New" to "Edit Message As New" (same as in the menu)

Changed "as" to "As" in "Mark Message as..." to make it more consistent with
the menu.

Comment 7

[R.J. Keller]

Comment on attachment 149226 [details] [diff] [review]
New patch with some more shortcuts and other corrections

>    </tr>
> -  <tr>
> +    <tr>
> +    <td>Remove Named Anchors</td>
> +    <td>Ctrl+Shift+A</td>

There is a slight alignment problem here. It's no big deal, but try to remember
to keep everything aligned consistently.

>    <tr>
> -    <td>Send Message Now</td>
> +    <td>Send Message Now (message will be sent later if offline)</td>
>      <td>Ctrl+Enter</td>
>      <td>Cmd+Enter</td>

I don't feel this message is necessary. If the user wanted to know what would
happen if they are offline, they can look in the help files.

> -    <td>Exit Mozilla</td>
> -    <td>Ctrl+Q</td>
> -    <td>Cmd+Q</td>
> -    <td>Ctrl+Q</td>

Why are we removing this?


As always, thanks for the patches!

Comment 8

[Stefan [:stefanh]]

> > -    <td>Exit Mozilla</td>
> > -    <td>Ctrl+Q</td>
> > -    <td>Cmd+Q</td>
> > -    <td>Ctrl+Q</td>
> Why are we removing this?

It's already in "General Mozilla Shortcuts" (shortcuts.xhtml):
http://lxr.mozilla.org/seamonkey/source/extensions/help/resources/locale/en-﷒0﷓

I'll fix the other stuff later today.

Comment 9

[Stefan [:stefanh]]

Attachment: New version that fixes the alignment and removes "message will be sent later if offline"

Comment 10

[Stefan [:stefanh]]

Patch checked in by Neil --> Fixed

Comment 11

[Stefan [:stefanh]]

Oops...