Closed Bug 244531 Opened 20 years ago Closed 20 years ago

allow a hidden pref ("imageblocker.enabled") to hide image blocking context menu UI

Categories

(SeaMonkey :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.7final

People

(Reporter: sspitzer, Assigned: sspitzer)

Details

(Keywords: verified1.7)

Attachments

(1 file)

allow a hidden pref ("imageblocker.enabled") to hide image blocking context menu UI.

on request of a browser vendor / distributor.

I'll attach a patch for review.

aiming for Mozilla 1.7, as that's the long lived branch that people will be
shipping off of.
I didn't define a default for this pref, but I could. 

I'll request a r= from neil and see what he thinks.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7final
Attachment #149217 - Flags: review?(neil.parkwaycc.co.uk)
mike, could you review?
Comment on attachment 149217 [details] [diff] [review]
patch

so we're not touching the Tools->Image Manager UI options or the pref panel?  I
can live with that

I don't think we need to define a default value in this case, but if we were
going to hide the other UI elements I'd want one
Attachment #149217 - Flags: review?(neil.parkwaycc.co.uk) → review+
> so we're not touching the Tools->Image Manager UI options or the pref panel?  I
> can live with that

right, this pref only affects the context menu item.  and for Mozilla 1.7, this
pref would not be set, so there would be no change.  it is for other browser
distrbutors.

> I don't think we need to define a default value in this case, but if we were
> going to hide the other UI elements I'd want one

ok, thanks for the review.
for some history, see http://bugzilla.mozilla.org/show_bug.cgi?id=208882

thanks to dveditz for pointing that out.
to summarize the relation ship to
http://bugzilla.mozilla.org/show_bug.cgi?id=208882, this pref does less than it
used too.

now, we just use this pref to hide the context menu item.  

but as mike points out, the rest of the feature is there.
Comment on attachment 149217 [details] [diff] [review]
patch

sr=dveditz
Attachment #149217 - Flags: superreview+
Attachment #149217 - Flags: approval1.7?
note, this fix will be on the 1.7 branch only.

I won't be adding this patch to the trunk.  

as per http://bugzilla.mozilla.org/show_bug.cgi?id=208882, that pref is dead.

but 1.7 is the successor to 1.4, and this was in 1.4.
Comment on attachment 149217 [details] [diff] [review]
patch

a=chofmann for 1.7
Attachment #149217 - Flags: approval1.7? → approval1.7+
fix landed on the 1.7 branch only.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
If this patch only affects the context menu, shouldn't the pref name say 
dat? As of now it sounds like it could disable the whole blocking 
mechanism.
it is misleand, but that's the pref that 1.4 used.  (1.4 did more disabling than
1.7 will do)

It's staying on the 1.7 branch, to encourage people who used 1.4 to move to 1.7.
s/misleand/misleading
Keywords: fixed1.7
seems this was also landed on aviary
Whiteboard: fixed-aviary1.0
if it did, it would have no effect whatsoever.
Whiteboard: fixed-aviary1.0
verified
Status: RESOLVED → VERIFIED
Keywords: fixed1.7verified1.7
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: