244558 - cookperm.txt -> hostperm.1

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Roaming, defect)

Description

[Ben Bucksch (:BenB)]

Comment 1

[[e-mail]]

mvl, wanna take this?

Comment 2

[[e-mail]]

see http://bugzilla.mozilla.org/show_bug.cgi?id=228629#c4

Comment 3

[Ben Bucksch (:BenB)]

> (also, how do you propose to keep the filenames in your
> new code synchronized with changes to other respective modules, such as has
> happened here?)

I don't expect profile filenames to change ;-)

Thanks for taking this. Should be trivial. grep finds appearances in files.xul
and filedescr.properties.

Comment 4

[Ben Bucksch (:BenB)]

r=BenB for the patch :)

(my tree is still updating)

Comment 5

[Ben Bucksch (:BenB)]

cert7.db changed to cert8.db, too.

Comment 6

[Ben Bucksch (:BenB)]

Filename changes may cause dataloss in edge cases, e.g. when you upgrade, but
your local profile is not the latest one (or - even worse - fresh) when you run
the new build the first time. Building explicit support for profile file name
changes into roaming would complicate the code. Just supporting multiple
filenames per item would make sense, but would cause strange effects
(transferring both versions forever, spurious files for new profiles).

Comment 7

[Ben Bucksch (:BenB)]

Attachment: v1

Patch for both files.

I didn't change the description "Cookie Permissions", assuming that it contains
only cookie and image permissions and image permissions are unimportant in
comparison. If other types of data exist there (e.g. popup blocking), we'd need
to change the description.

Comment 8

[Ben Bucksch (:BenB)]

-> me. please r.

Comment 9

[Ben Bucksch (:BenB)]

ccing some crypto guys. I don't think that filename changes are a good
versioning strategy, at least for the browser. But I don't have a better suggestion.

Comment 10

[Ben Bucksch (:BenB)]

*** Bug 244793 has been marked as a duplicate of this bug. ***

Comment 11

[Nelson Bolyard (seldom reads bugmail)]

Ben, since you added me to the CC list, would you care to explain what
you're trying to do, and why, and what question you have for me about it?
Thanks.

Comment 12

[Ben Bucksch (:BenB)]

dwitte: ping?

Nelson, see comment 9. It seems NSS changes the filename (in the profile) of
certdb whenever you have a format change. I'd prefer, if it didn't, because it
will cause problems for roaming (as described in this bug, esp. comment 6), and
I don't think it's a good idea in general, no other critical files there do
that. I just wanted to point out the problem to you. If there's need for
discussion, we can move to npm.crypto and/or .prefs.

Comment 13

[[e-mail]]

Comment on attachment 149250 [details] [diff] [review]
v1

sorry for the delay. instead of "cookie permissions" you may want to call it
"host permissions", hence the new filename, but that's up to you since it's
your module. ;)

r=dwitte

Comment 14

[Henrik Gemal]

Any chance we could get this one into the tree?

the file should be called "Cookie/Image permission" or just "Permission File"
like it says in the file itself.

Comment 15

[[e-mail]]

you might want to try alecf for sr here...

Comment 16

[Pete Zha]

Ben, shall we check in this patch since it has got r= and sr= already

Comment 17

[Henrik Gemal]

Ben: could you please do the checkin

Comment 18

[Pete Zha]

just checked in