244589 - [Roaming] Upload hangs for fresh profile (files non-existant)

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Roaming, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Create new profile
2. Enable roaming, with default file selection (bookmarks, address book, cookies).
3. Close browser (should upload profile files)

I used a roaming server account which has already files (from another machine),
not sure what happens when the server has no files yet. I don't remember if I
got a conflict dialog - if so, I probably selected the server files.

Actual result:
The transfer progress window never closes (appearantly, didn't wait long).
I think because abook.mab doesn't exist yet.

Expected result:
Skip file silently, keeping any version possibly lying on server.


Bug description is too sketchy/vage, need more precise info, need to test more,

Comment 1

[Kim Scarborough]

I'm getting hangs on uploads and downloads using an old Netscape-4.x roaming 
profile. I unselected everything except "Manual user preferences". Mozilla 
bulid 2004052609 for Windows, server is Apache 2.0.49 with mod_roaming 2.0.0. 
Server logs show (both on attempted uploads and downloads) an anonymous request 
for listing.xml (which gets a 401 error), immediately followed by an 
authenticated request (which gets a 404). Browser then hangs until I 
click "cancel".

Got an example copy of listing.xml? I want to see what happens if I put a copy 
in the roaming directory.

Comment 2

[Kim Scarborough]

Ha! Success.

I put a one-line "listing.xml" file in the roaming directory (with just <?xml 
version="1.0" encoding="UTF-8"?>) and then exited Mozilla. Now it's uploading 
and downloading fine.

It is still hanging after upload, however. The upload happens, the checkmark 
appears, but the dialog sits there until you hit "cancel". (Doesn't happen on 
download). Should that be a new bug?

Comment 3

[MegaZone]

(In reply to comment #2)
> I put a one-line "listing.xml" file in the roaming directory (with just <?xml 
> version="1.0" encoding="UTF-8"?>) and then exited Mozilla. Now it's uploading 
> and downloading fine.

It just needs to exist - I fixed it by 'touch listing.xml'.

I'm seeing a few things myself:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040529

Must manually create listing.xml file on server to enable.

Passwords - will not stay checked

Fill Form data - will not stay checked

Helper App Settings - blocks upload/download (freezes on Roaming
profile conflicts)

Private Keys - blocks upload/download (freezes on Roaming profile
conflicts)

Security Module Databae - blocks upload/download (freezes on Roaming
profile conflicts)

If both Private Keys and Security Module Database are checked then you
get: Transfer error with file "undefined": NS_ERROR_ILLEGAL_VALUE

Window doesn't close on Roaming Transfer upload - 'Cancel' is a bit
confusing as the open to close the window.

Not sure if I should really open separate bugs for these...

Comment 4

[Ben Bucksch (:BenB)]

Fix for this bug is included in patch in bug 246710.

Comment 5

[Ben Bucksch (:BenB)]

The problem was that the DOM loading function freaked out, if it got an empty
filename. I think I tested this with 1.4 and it worked there. In any case, I
fixed it by moving the DOM creation after the check for the filename being empty.

Comment 6

[Ben Bucksch (:BenB)]

Fix checked in. Please test the next nightly.

Comment 7

[Ben Bucksch (:BenB)]

please verify