244650 - Searching for commentor or owner returns fewer results then just searching for commentor

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P3)

Description

[Jon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630 Galeon/1.3.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630 Galeon/1.3.8

If you select within the 'Email and numbering' section both the commenter and
bug owner checkboxes and a name to search you will get fewer results then if you
just had the commenter checkbox selected.  The example I tried was in
landfill/tip with 'contains' and the string 'justdave'; with both boxes checked
I get 50 bugs while with just commenter checked I get 529 bugs matching.  I
would expect to have the same or more bugs when both boxes are checked.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Joel Peshkin]

This problem appears to be the result of some strange special handling of
longdescs in Search.pm

In the section ...  
 if ($params->param("emaillongdesc$id")) {
     if (my $list = $self->ListIDsForEmail($type, $email)) {

longdescs gets joined in and the resulting IS NOT NULL gets added to wherepart,
so it gets ANDED in.  That section whould be removed and instead, this should
work just like the cclist... (by adding longdesc right into the code below)

        foreach my $field ("assigned_to", "reporter", "cc", "qa_contact") {
            if ($params->param("email$field$id")) {
                push(@clist, $field, $type, $email);
            }

That would be just fine, but the general code down below for longdescs does not
include the ListIDsForEmail optimization so, it should work but be extremely
slow. So, the ListIDsForEmail optimization should be ported to the  
"^long_?desc," handler.

Comment 2

[Jon]

One workaround appears to be to search by 'matches regexp' instead of 'contains'
or 'is'.  Another is to search for the commenter on a separate search.

Comment 3

[Joel Peshkin]

Attachment: v1

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 149323 [details] [diff] [review]
v1

>+                 push(@supptables, "LEFT JOIN longdescs $table ON $table.bug_id = bugs.bug_id $extra AND $table.who IN ($list)");

MySQL docs say:

---snip---
You should generally not have any conditions in the ON part that are used to
restrict which rows you want in the result set, but rather specify these
conditions in the WHERE clause. There are exceptions to this rule.
---snip---

I can't find a list of what those exceptions are though.

However, there's lots of places this syntax is used in Search.pm, and if we fix
it, we should fix them all, and that's another bug.

So r=justdave

Comment 5

[Joel Peshkin]

checked in