244678 - Change bundle identifier from org.mozilla.navigator to org.mozilla.camino

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Greg K.]

Camino 0.8b's Info.plist file retains some outdated names from its' own past.

CFBundleIdentifier: org.mozilla.navigator (shows up in crash reports; change to
org.mozilla.Camino?)
CFBundleSignature: CHIM (is this a type/creator code relic? Change to CMNO or CAMI?)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

You still need a bundle signature in OS X for LaunchServices; it's the
replacement or Cocoa equivalent for creator code.  For compatability reasons
these typically don't change (and particularly now that 3rd-party prefpanes need
the signature).

I'm unsure of where/in which ways the org.mozilla.navigator is used, but I've
noticed in other apps that change names that this string does seem to change
with name changes.  According to LXR, it only shows up in the Info.plist(s):
http://lxr.mozilla.org/mozilla/search?string=org.mozilla.navigator
It apparently gets used in the name of the plist the Finder uses to store
Camino's NavServices history (last folder used, etc.):
~/Library/Preferences/org.mozilla.navigator.plist

One could make an argument for changing these for 1.0 (and therefore probably
for 0.9 so it's not a "last minute" thing) or for WONTFIXing.

There's also a 
CFBundleGetInfoString: Camino 0.8+, © 2003-2004 The Mozilla Foundation
that doesn't seem to show up anywhere (the About Camino and Get Info both show
the 1998-2005 dates) for some reason.

Since this appears either to be a quick fix or a quick won't fix and something
that shouldn't appear suddenly for 1.0 if it is to be changed, pulling the
camino0.9 ? flag....

Comment 2

[Josh Aas]

Changing that stuff has some significant implications... we should definitely
think about this but it shouldn't hold up a release.

Comment 3

[Simon Fraser [no longer active]]

I vote for chaning the bundle identifier soon; most people will not associate
org.mozilla.navigator prefs with Camino.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> I vote for chaning the bundle identifier soon; most people will not associate
> org.mozilla.navigator prefs with Camino.

Since there's not going to be a full development cycle post 0.9 now, should this
change happen right after 0.9b?

Presumably there's some code needed to migrate the old file in addition to
simply changing the string in the plist.

Comment 5

[Wevah (Nate Weaver)]

(In reply to comment #4)
> Presumably there's some code needed to migrate the old file in addition to
> simply changing the string in the plist.

Yeah, I think we could just load in the old values using -[NSUserDefaults
persistentDomainForName:], and then set a "Old Defaults Imported" bool in the
new file, or something like that.

Comment 6

[Simon Fraser [no longer active]]

(In reply to comment #5)
> Yeah, I think we could just load in the old values using -[NSUserDefaults
> persistentDomainForName:], and then set a "Old Defaults Imported" bool in the
> new file, or something like that.

Is this really worth it? I don't think we save anything critical in user defaults.

Comment 7

[Wevah (Nate Weaver)]

True; the only thing we save is toolbar layout and other OS built-ins.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #7)
> True; the only thing we save is toolbar layout and other OS built-ins.

Having to reset your toolbars' layouts and the history and bookmarks columns and
splitter position and whatnot would be an annoyance, but not any sort of
critical dataloss.

Comment 9

[Simon Fraser [no longer active]]

Definately blocking 1.0. I sent mail to my plugin developers list to see if this
will break anyone.

Comment 10

[Mark Mentovai]

Attachment: Do it.

This should be done now.  Now, as in, right before 1.0a1.  It's either now or
never, folks.

Comment 11

[Mark Mentovai]

It's now, folks.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since from Mark's forum post it seems that CHIM was changed to MOZC instead of
just the bundle identifier change, has that new CFBundleSignature been
registered with Apple to keep it unique?
 
http://developer.apple.com/datatype/creatorcode.html  

(Was/is CHIM registered, too, since it's still valid for custom prefPanes?)

Comment 13

[Simon Fraser [no longer active]]

I registered MOZC with a MoFo address under Josh's name.