244795 - Drag and drop child onto parent should do nothing (see URL for test details)

Status: RESOLVED INACTIVE

(Toolkit :: Places, defect, P5)

Description

[Tracy Walker [:tracy]]

* As part of your bookmarks file you need a folder(lets' call it folder 'A')
that contains bookmarks and another folder(let's call this folder 'A1' (read
Asub1)) that contains bookmarks as well. 

Steps to reproduce:
1. Select Bookmarks | Manage Bookmarks.
2. Select folder A1 then drag&drop it onto or within folder A.

tested results: The folder A1 is moved to the bottom of the list in folder A.

Expected results:  No change in the bookmarks list should occur.

note: see URL above for further description of parent/child drag&drop expectations

Comment 1

[Wayne Mery (:wsmwk)]

This bug is invalid, if the testcase URL is outdated.  

Given that bookmarks can be reordered with drag and drop, most certainly step 3
"Select folder A1 then drag&drop it ... within folder A" should be permissible
to move the folder whereever one likes. The other part of step 3 "... onto
folder A" is consistent with drag and drop of bookmarks, in that dropping
something on the folder positions it at the end of the folder.

I think the reference URL needs to be revised and the bug marked invalid.

Comment 2

[Tracy Walker [:tracy]]

Yes, reodering via dnd within a folder is allowed. Thus "within" should be
removed from the instuctions in #2 in this bug and at URL #3. Everything else is
valid. Drag and drop a folder onto it's direct parect folder icon should *NOT*
move the subfolder to the bottom of its parent folder.  It should get a crossed
out circle symbol indicating that particular drop is not allowed. The same goes
for dnd of a bookmark onto its parent folder icon.  It shouldn't be allowed.

This affects Firefox as well. What product/component does it belong under?

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to comment #2)
> Yes, reodering via dnd within a folder is allowed. Thus "within" should be
> removed from the instuctions in #2 in this bug and at URL #3. Everything else is
> valid. Drag and drop a folder onto it's direct parect folder icon should *NOT*
> move the subfolder to the bottom of its parent folder.  It should get a crossed
> out circle symbol indicating that particular drop is not allowed. The same goes
> for dnd of a bookmark onto its parent folder icon.  It shouldn't be allowed.

Matti, any guidance? [No one is on IRC]

It's hard to believe the developers of both FF and suite overlooked two of five
test points.  

Or, perhaps they ignored those points to simplify the initial implementation? If
so, why didn't they file a followup bug to resolve it at a later date?

Seems more likely they changed their standards in the implimentation, but didn't
change the reference.  Is there reason to believe otherwise?  


> This affects Firefox as well. What product/component does it belong under?

possibly both (if it's necessary at all)

Comment 4

[Phoenix]

Moving to appropriate general component

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.