244803 - no "new mail" icon for secure IMAP server and shared IMAP Inbox folder

Status: RESOLVED EXPIRED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Flavio Stanchina]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040401 Debian/1.6-4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040401 Debian/1.6-4

The server icon for an IMAP-over-SSL account doesn't change when new mail has
been received. Similarly, the Inbox icon of an IMAP account doesn't change if
Mail thinks the folder is shared.

Reproducible: Always
Steps to Reproduce:
1. configure IMAP SSL account 
2. wait for new mail
3. server icon doesn't show that new mail arrived

Comment 1

[Flavio Stanchina]

Attachment: patch for skin/modern/messenger/folderPane.css

Changes to skin/modern/messenger folderPane.css:
* add icon for (specialFolder-Inbox, imapShared-true)
* add icon for (specialFolder-Inbox, imapShared-true, newMessages-true)
* add icon for (biffState-NewMail, isServer-true, serverType-pop3|imap,
isSecure-true)

New/updated icons to follow...

Comment 2

[Flavio Stanchina]

Attachment: new/updated icons

Changes to skin/modern/messenger/icons/:
* folder-inbox-share.gif, folder-inbox-share-open.gif:
  moved down two pixels to align the "legs" with folder-share.gif
* folder-inbox-share-new.gif:
  folder-inbox-share-open.gif plus a 'new' arrow
* server-remote-lock.gif:
  moved down three pixels to make room for arrow (see below)
* server-remote-lock-new.gif:
  server-remote-lock.gif plus a 'new' arrow

Comment 3

[Flavio Stanchina]

Forgot to mention: patch and new icons are for the Modern theme only. I'm sorry
but I don't have the time to fix Classic.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

You'll need review and super-review from here:

http://www.mozilla.org/owners.html

Comment 5

[David :Bienvenu]

Comment on attachment 149382 [details] [diff] [review]
patch for skin/modern/messenger/folderPane.css

giving to Neil for sr...

Comment 6

[[e-mail]]

Comment on attachment 149382 [details] [diff] [review]
patch for skin/modern/messenger/folderPane.css

>+ * I need !important to override folder-share.gif (don't ask me why). */
Because your rules are in the wrong place. Tree pseudoelements don't have
weighting, so you need to put all your imap shared rules together.

>+treechildren::-moz-tree-image(folderNameCol, biffState-NewMail, isServer-true, serverType-pop3, isSecure-true) {
>+  list-style-image: url("chrome://messenger/skin/icons/server-remote-lock-new.gif") !important;
>+}
>+
>+treechildren::-moz-tree-image(folderNameCol, biffState-NewMail, isServer-true, serverType-imap, isSecure-true) {
>+  list-style-image: url("chrome://messenger/skin/icons/server-remote-lock-new.gif") !important;
>+}
Modern already has a rule for new secure mail.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Flavio: any intentions to resurrect this patch?

Comment 8

[Flavio Stanchina]

(In reply to comment #7)
> Flavio: any intentions to resurrect this patch?

I've switched to Firefox and Thunderbird so I've lost interest in this problem
and I don't have much time to devote to it. Anyway, I think the problem and fix
are clear from this bug report, so anyone familiar with the relevant CSS file
should be able to fix it very quickly (and you should be able to use the icons
as they are).

Comment 9

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 10

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.