244876 - Remove 2 unnecessary memsets in nsTextFrame.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Rene Pronk]

See:
http://groups.google.nl/groups?hl=nl&lr=&ie=UTF-8&frame=right&th=55c27fe62dd23160&seekm=c94ut5%24bn31%40ripley.netscape.com#link1

Remove these 2 memset in nsTextFrame.cpp since they seem do nothing usefull.
http://lxr.mozilla.org/mozilla/source/layout/html/base/src/nsTextFrame.cpp#164
http://lxr.mozilla.org/mozilla/source/layout/html/base/src/nsTextFrame.cpp#187

I'll try to make a patch once my fresh build is done.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note roc's idea of leaving them in debug builds and using 0xdd or something.  I
like that thought.

Comment 2

[Rene Pronk]

Attachment: patch

Voila. I didn't add a debug variable and any assertion because they both
already exist: the variable containing the length is mBufferLen and there are
already 2 assertions at what seems to be the most strategic place to put one:
http://lxr.mozilla.org/mozilla/source/layout/html/base/src/nsTextFrame.cpp#1647

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 149674 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.  This made Tp drop by about 1%, as advertised.  ;)

For future reference, diffs with more context (-u8, say) and using the -p option
are a lot easier to review....