244886 - Convert compose window to menulist type="description"

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[[e-mail]]

A new widget got added which has builtin support for the two-part display used
by the identity popup. We can convert the identity popup to the new widget and
remove the special support that currently exists.

Comment 1

[[e-mail]]

Attachment: Patch to content

This is just the patch to the JS, the special theme styles need to be removed.

Comment 2

[Stefan Borggraefe]

Attachment: Patch to everything

I tested this with both Seamonkey and TB.

Note: The account name in TB was differently styled on different platforms. See


http://lxr.mozilla.org/mozilla/source/mail/components/compose/skin/mac/messengercompose.css#380

http://lxr.mozilla.org/mozilla/source/mail/components/compose/skin/messengercompose.css#414


For the new menulist type the same style is used for all paltforms:

http://lxr.mozilla.org/mozilla/source/toolkit/skin/mac/menulist.css#52
http://lxr.mozilla.org/mozilla/source/toolkit/skin/win/menulist.css#62

I'm not sure why the Mac used to have a different style and whether it should
be moved to menulist.css.

I also removed the " - " delimiter between the menulist-label and -description.
I think something like this should be added if globally so all menulists of
this type look the same. But I think this won't be necessary, because the
different stylings of the label and the description is enough to distinct the
two.

Comment 3

[[e-mail]]

Comment on attachment 149992 [details] [diff] [review]
Patch to everything

>-  if (identityListPopup)
>-    FillIdentityListPopup(identityListPopup);
>+  if (identityList)
>+      FillIdentityList(identityList);
You got the indentation wrong here, although you got it right in mail/

Comment 4

[Stefan Borggraefe]

Comment on attachment 149992 [details] [diff] [review]
Patch to everything

Patch bitrotted. :-(

Comment 5

[Stefan Borggraefe]

Attachment: Updated patch

I also corrected Neil's nit from comment 3.

Comment 6

[Scott MacGregor]

Comment on attachment 170278 [details] [diff] [review]
Updated patch

will I still get my pretty grey colored text from the account line? 

i.e.

http://lxr.mozilla.org/mozilla/source/mail/themes/qute/mail/compose/messengercompose.css#386

if not, I can add a style rule to do that for me on my own :)

Comment 7

[[e-mail]]

(In reply to comment #6)
>will I still get my pretty grey colored text from the account line? 
As well as fixing the other bitrot, some of the associated styles weren't consistently defined in all toolkit themes so I fixed those too.